Schema $ref of $ref not working

[mpoiriert]

This is seem to be a valid schema but it's not loaded properly:

{
  "definitions": {
    "Response": {
      "$ref": "User"
    },
    "User": {
      "properties": {
        "username": {
          "type": "string"
        }
      }
    }
}

I would expect the Reponse definition to "import" the User definition but it doesn't. This can easily be seen with the getMockSignature of a model since it does get the reference from properties but not from himself.

[webron]

Technically, that's not a valid $ref definition, it really should be #/definitions/User. There's a related discussion in swagger-spec - OAI/OpenAPI-Specification#135.

[mpoiriert]

Sorry this is not the concern of the bug here is the updated schema:

{
  "definitions": {
    "Response": {
      "$ref": "#/definitions/User"
    },
    "User": {
      "properties": {
        "username": {
          "type": "string"
        }
      }
    }
}

This is not working.

I did do a fix for another concern (#162) but this doesn't fix this case since it's not the root problem of this.

[webron]

Fair enough, thank you for the contributions! 👍

[fehguy]

the issue above should be resolved with #162. Please reopen if not.

[mpoiriert]

This is not related.

The problem is in the SwaggerClient.prototype.buildFromSpec and the Model class.

In the buildFromSpec arround line 121

  for(key in this.definitions) {
    var model = new Model(key, this.definitions[key]);
    if(model) {
      models[key] = model;
    }
  }

A new Model class is instanciate but none of the code in the for and the Model contructor take in consideration that a definition could be a reference on another definition...

[fehguy]

This can be handled by #152

[whitlockjc]

If all you need is the reference dereferencing, you could use json-refs. If you want to construct an object model from a Swagger document, I don't think #152 will help.

[whitlockjc]

This has been resolved.