Skip to content

Commit ba6017e

Browse files
ctillercopybara-github
authored andcommitted
Fix read data frames tracing
ztrace was ignoring most read data frames, resulting in confusing traces PiperOrigin-RevId: 751598688
1 parent bfc4435 commit ba6017e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/core/ext/transport/chttp2/transport/frame_data.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,13 @@ grpc_error_handle grpc_chttp2_data_parser_parse(void* /*parser*/,
152152
grpc_slice_buffer_add(&s->frame_storage, slice);
153153
grpc_chttp2_maybe_complete_recv_message(t, s);
154154

155-
if (is_last && s->received_last_frame) {
155+
if (is_last) {
156156
t->http2_ztrace_collector.Append(grpc_core::H2DataTrace<true>{
157157
t->incoming_stream_id,
158158
(t->incoming_frame_flags & GRPC_CHTTP2_DATA_FLAG_END_STREAM) != 0,
159159
t->incoming_frame_size});
160+
}
161+
if (is_last && s->received_last_frame) {
160162
grpc_chttp2_mark_stream_closed(
161163
t, s, true, false,
162164
t->is_client

0 commit comments

Comments
 (0)