Skip to content

Case-sensitive Set-Cookie parsing #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vlm opened this issue May 7, 2020 · 0 comments · Fixed by #207
Closed

Case-sensitive Set-Cookie parsing #205

vlm opened this issue May 7, 2020 · 0 comments · Fixed by #207
Assignees
@artemredkin
Labels
good first issue Good for newcomers kind/bug Feature doesn't work as expected.
Milestone
1.2.0

Comments

@vlm
Copy link
Contributor

vlm commented May 7, 2020

The current parsing is case-sensitive:

https://github.com/swift-server/async-http-client/blob/master/Sources/AsyncHTTPClient/HTTPClient%2BHTTPCookie.swift#L91

Need to make it case-insensitive as per https://tools.ietf.org/html/rfc6265#section-5.2.2
@weissi weissi added kind/bug Feature doesn't work as expected. good first issue Good for newcomers labels May 7, 2020
@weissi weissi added this to the 1.2.0 milestone May 7, 2020
@weissi weissi changed the title [Bug] Case-sensitive Set-Cookie parsing Case-sensitive Set-Cookie parsing May 7, 2020
@artemredkin artemredkin self-assigned this May 7, 2020
@artemredkin artemredkin mentioned this issue May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemredkin artemredkin

Labels
good first issue Good for newcomers kind/bug Feature doesn't work as expected.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

make cookie parsing case insensitive swift-server/async-http-client
3 participants
@vlm @artemredkin @weissi