Refactor Operation

Author: Andrea-Scuderi

Examples/LambdaFunctions/Sources/ProductAPI/ProductLambda.swift

@@ -25,12 +25,9 @@ enum Operation: String {
     case update
     case delete
     case list
-    case unknown
 }
 
-struct EmptyResponse: Codable {
-    
-}
+struct EmptyResponse: Codable {}
 
 struct ProductLambda: LambdaHandler {
 
@@ -61,35 +58,34 @@ struct ProductLambda: LambdaHandler {
         return tableName
     }
 
-    init(context: Lambda.InitializationContext) {
-        
-        let handler = Lambda.env("_HANDLER") ?? ""
-        self.operation = Operation(rawValue: handler) ?? .unknown
+    init(context: Lambda.InitializationContext) throws {
 
+        guard let handler = Lambda.env("_HANDLER"),
+            let operation = Operation(rawValue: handler) else {
+                throw APIError.invalidHandler
+        }
+        self.operation = operation
         self.region = Self.currentRegion()
-        logger.info("\(Self.currentRegion())")
 
         let lambdaRuntimeTimeout: TimeAmount = .seconds(dbTimeout)
         let timeout = HTTPClient.Configuration.Timeout(
             connect: lambdaRuntimeTimeout,
             read: lambdaRuntimeTimeout
         )
-        
+    
         let configuration = HTTPClient.Configuration(timeout: timeout)
         self.httpClient = HTTPClient(
             eventLoopGroupProvider: .shared(context.eventLoop),
             configuration: configuration
         )
 
         self.db = AWSDynamoDB.DynamoDB(region: region, httpClientProvider: .shared(self.httpClient))
-        logger.info("DynamoDB")
-        self.tableName = (try? Self.tableName()) ?? ""
-        
+        self.tableName = try Self.tableName()
+
         self.service = ProductService(
             db: db,
             tableName: tableName
         )
-        logger.info("ProductService")
     }
 
     func handle(

Examples/LambdaFunctions/Sources/ProductAPI/ProductLambdaHandler.swift

@@ -102,10 +102,6 @@ struct ProductLambdaHandler: EventLoopLambdaHandler {
                         }
                 }
                 return list
-            case .unknown:
-                logger.info("unknown")
-                let value = APIGateway.V2.Response(with: APIError.handlerNotFound, statusCode: .forbidden)
-                return context.eventLoop.makeSucceededFuture(value)
             }
     }
 

Examples/LambdaFunctions/Sources/ProductAPI/ProductService.swift

@@ -20,7 +20,7 @@ public enum APIError: Error {
     case invalidItem
     case tableNameNotFound
     case invalidRequest
-    case handlerNotFound
+    case invalidHandler
 }
 
 extension Date {