Skip to content

Remove callback based LambdaHandler #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabianfett opened this issue Jul 21, 2021 · 1 comment · Fixed by #222
Closed

Remove callback based LambdaHandler #212

fabianfett opened this issue Jul 21, 2021 · 1 comment · Fixed by #222
Assignees
@fabianfett
Labels
⚠️ semver/major Breaks existing public API.
Milestone
1.0.0-alpha.1

Comments

@fabianfett
Copy link
Member

We should remove the Callback LambdaHandler.
@fabianfett fabianfett added the ⚠️ semver/major Breaks existing public API. label Jul 21, 2021
@fabianfett fabianfett added this to the 1.0.0-alpha.1 milestone Jul 21, 2021
@fabianfett fabianfett self-assigned this Jul 21, 2021
@fabianfett fabianfett mentioned this issue Aug 19, 2021
Merged
@saltzmanjoelh
Copy link

Hi, sorry to comment on an already closed issue. I wasn't sure if I should open a new issue or continue with this one?

I noticed that the readme has the closure based examples. Do you want some help updating them? If so, would you like them to simply use the async handle(event:context) form like in LambdaTestingTests.testCodableClosure?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabianfett fabianfett

Labels
⚠️ semver/major Breaks existing public API.
Projects
None yet
Milestone
1.0.0-alpha.1
Development

Successfully merging a pull request may close this issue.

Drop sync and closure APIs fabianfett/swift-aws-lambda-runtime
2 participants
@saltzmanjoelh @fabianfett