Skip to content

Lambda.Context should be a struct #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabianfett opened this issue Jul 21, 2021 · 2 comments
Closed

Lambda.Context should be a struct #215

fabianfett opened this issue Jul 21, 2021 · 2 comments
Labels
good first issue Good for newcomers ⚠️ semver/major Breaks existing public API.
Milestone
1.0.0-alpha.1

Comments

@fabianfett
Copy link
Member

Lambda.Context is currently a class. But it is just a wrapper around values. This should be a value type.
@fabianfett fabianfett added the ⚠️ semver/major Breaks existing public API. label Jul 21, 2021
@fabianfett fabianfett added this to the 1.0.0-alpha.1 milestone Jul 21, 2021
@fabianfett fabianfett added the good first issue Good for newcomers label Jul 21, 2021
@fabianfett
Copy link
Member Author

fabianfett commented Jul 21, 2021 •
edited
Loading

Basically we need the changes from here, minus the addition of Baggage.

https://github.com/swift-server/swift-aws-lambda-runtime/pull/167/files

@jareyesda jareyesda mentioned this issue Aug 8, 2021
Merged
@fabianfett
Copy link
Member Author

Thanks @jareyesda for fixing this! And congrats to your first open source contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers ⚠️ semver/major Breaks existing public API.
Projects
None yet
Milestone
1.0.0-alpha.1
Development

No branches or pull requests
1 participant
@fabianfett