Convert sourcekitd response to ConcurrentEdits

Author: lokesh-tr

Sources/SourceKitLSP/Swift/MacroExpansion.swift

@@ -29,17 +29,10 @@ struct MacroExpansion: RefactoringResponse {
   /// The resulting array of `RefactoringEdit` of a semantic refactoring request
   var edits: [RefactoringEdit]
 
-  init(title: String, uri: DocumentURI, refactoringEdits: [RefactoringEdit]) {
+  init(title: String, snapshot: DocumentSnapshot, refactoringEdits: [RefactoringEdit]) {
     self.title = title
-    self.uri = uri
-    self.edits = refactoringEdits.compactMap { refactoringEdit in
-      if refactoringEdit.bufferName.isEmpty {
-        logger.fault("Unable to retrieve some parts of the expansion")
-        return nil
-      }
-
-      return refactoringEdit
-    }
+    self.uri = snapshot.uri
+    self.edits = refactoringEdits.concurrent(to: snapshot)  // Bug: Line number is wrong and test fails
   }
 }
 

Sources/SourceKitLSP/Swift/Refactoring.swift

@@ -15,7 +15,7 @@ import LanguageServerProtocol
 import SourceKitD
 
 protocol RefactoringResponse {
-  init(title: String, uri: DocumentURI, refactoringEdits: [RefactoringEdit])
+  init(title: String, snapshot: DocumentSnapshot, refactoringEdits: [RefactoringEdit])
 }
 
 extension RefactoringResponse {
@@ -81,7 +81,7 @@ extension RefactoringResponse {
       return nil
     }
 
-    self.init(title: title, uri: snapshot.uri, refactoringEdits: refactoringEdits)
+    self.init(title: title, snapshot: snapshot, refactoringEdits: refactoringEdits)
   }
 }
 

Sources/SourceKitLSP/Swift/RefactoringEdit.swift

@@ -12,6 +12,8 @@
 
 import LanguageServerProtocol
 import SourceKitD
+import SwiftParser
+import SwiftSyntax
 
 /// Represents an edit from semantic refactor response. Notionally, a subclass of `TextEdit`
 @_spi(Testing) public struct RefactoringEdit: Hashable, Sendable, Codable {
@@ -59,3 +61,43 @@ extension RefactoringEdit: LSPAnyCodable {
     ])
   }
 }
+
+@_spi(Testing)
+public
+  extension Array where Element == RefactoringEdit
+{
+  func concurrent(to snapshot: DocumentSnapshot) -> [RefactoringEdit] {
+    let sequentialEdits = self.map { refactoringEdit in
+      let startUtf8Column = snapshot.lineTable.utf8ColumnAt(
+        line: refactoringEdit.range.lowerBound.line,
+        utf16Column: refactoringEdit.range.lowerBound.utf16index
+      )
+
+      let absoluteStartPosition = AbsolutePosition(utf8Offset: startUtf8Column)
+
+      let endUtf8Column = snapshot.lineTable.utf8ColumnAt(
+        line: refactoringEdit.range.upperBound.line,
+        utf16Column: refactoringEdit.range.upperBound.utf16index
+      )
+
+      let absoluteEndPosition = AbsolutePosition(utf8Offset: endUtf8Column)
+
+      return SourceEdit(range: absoluteStartPosition..<absoluteEndPosition, replacement: refactoringEdit.newText)
+    }
+
+    let concurrentEdits = ConcurrentEdits(fromSequential: sequentialEdits)
+
+    var refactoringEdits = [RefactoringEdit]()
+    for (i, concurrentEdit) in concurrentEdits.edits.enumerated() {
+      refactoringEdits.append(
+        RefactoringEdit(
+          range: snapshot.absolutePositionRange(of: concurrentEdit.range),
+          newText: concurrentEdit.replacement,
+          bufferName: self[i].bufferName  // Is there a better way to access bufferName after receiving concurrentEdits?
+        )
+      )
+    }
+
+    return refactoringEdits
+  }
+}

Sources/SourceKitLSP/Swift/SemanticRefactoring.swift

@@ -31,10 +31,10 @@ struct SemanticRefactoring: RefactoringResponse {
     self.edit = edit
   }
 
-  init(title: String, uri: DocumentURI, refactoringEdits: [RefactoringEdit]) {
+  init(title: String, snapshot: DocumentSnapshot, refactoringEdits: [RefactoringEdit]) {
     self.title = title
     self.edit = WorkspaceEdit(changes: [
-      uri: refactoringEdits.map { TextEdit(range: $0.range, newText: $0.newText) }
+      snapshot.uri: refactoringEdits.map { TextEdit(range: $0.range, newText: $0.newText) }
     ])
   }
 }