Skip to content

Commit c45b202

Browse files
authored
Merge pull request #1265 from owenv/owenv/androidvendor
Update vendor for android triples in fallback sdk
2 parents 946cd41 + dcac321 commit c45b202

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

Sources/SWBAndroidPlatform/Plugin.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ fileprivate func androidSDKAdditionalCustomProperties(ndk: AndroidSDK.NDK, hostO
307307
"MaximumDeploymentTarget": .plString("\(androidNdk.deploymentTargetRange.max)"),
308308
"LLVMTargetTripleEnvironment": .plString("android"), // FIXME: androideabi for armv7!
309309
"LLVMTargetTripleSys": .plString("linux"),
310-
"LLVMTargetTripleVendor": .plString("none"),
310+
"LLVMTargetTripleVendor": .plString("unknown"),
311311
])
312312
]),
313313
"Toolchains": .plArray([

Tests/SWBAndroidPlatformTests/SWBAndroidPlatformTests.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ fileprivate struct AndroidBuildOperationTests: CoreBasedTests {
263263
results.checkTask(.matchRuleType("Ld"), .matchRuleItemPattern(.suffix(Path("build/Debug-android/libdynamiclib.so").str))) { task in
264264
task.checkCommandLineMatches([
265265
.suffix(clang.str),
266-
"-target", "\(arch)-none-linux-android\(minOS)",
266+
"-target", "\(arch)-unknown-linux-android\(minOS)",
267267
"-shared",
268268
"--sysroot",
269269
.contains(Path("/toolchains/llvm/prebuilt/").str),
@@ -285,7 +285,7 @@ fileprivate struct AndroidBuildOperationTests: CoreBasedTests {
285285
results.checkTask(.matchRuleType("Ld"), .matchRuleItemPattern(.suffix(Path("build/Debug-android/tool").str))) { task in
286286
task.checkCommandLineMatches([
287287
.suffix(clang.str),
288-
"-target", "\(arch)-none-linux-android\(minOS)",
288+
"-target", "\(arch)-unknown-linux-android\(minOS)",
289289
"--sysroot", .contains(Path("/toolchains/llvm/prebuilt/").str),
290290
"-resource-dir",
291291
.and(.contains(Path("/toolchains/llvm/prebuilt/").str), .contains(Path("/lib/clang/").str)),
@@ -426,7 +426,7 @@ fileprivate struct AndroidBuildOperationTests: CoreBasedTests {
426426
results.checkTask(.matchRuleType("Ld"), .matchRuleItemPattern(.suffix(Path("build/Debug-android/libdynamiclib.so").str))) { task in
427427
task.checkCommandLineMatches([
428428
.suffix(clang.str),
429-
"-target", "\(arch)-none-linux-android\(minOS)",
429+
"-target", "\(arch)-unknown-linux-android\(minOS)",
430430
"-shared",
431431
"--sysroot",
432432
.contains(Path("/toolchains/llvm/prebuilt/").str),
@@ -451,7 +451,7 @@ fileprivate struct AndroidBuildOperationTests: CoreBasedTests {
451451
results.checkTask(.matchRuleType("Ld"), .matchRuleItemPattern(.suffix(Path("build/Debug-android/tool").str))) { task in
452452
task.checkCommandLineMatches([
453453
.suffix(clang.str),
454-
"-target", "\(arch)-none-linux-android\(minOS)",
454+
"-target", "\(arch)-unknown-linux-android\(minOS)",
455455
"--sysroot", .contains(Path("/toolchains/llvm/prebuilt/").str),
456456
"-resource-dir",
457457
.and(.contains(Path("/toolchains/llvm/prebuilt/").str), .contains(Path("/lib/clang/").str)),

0 commit comments

Comments
 (0)