Process the correct slice for multi-arch Linux XCFrameworks#1462
Open
vsarunas wants to merge 6 commits into
Open
Process the correct slice for multi-arch Linux XCFrameworks#1462vsarunas wants to merge 6 commits into
vsarunas wants to merge 6 commits into
Conversation
vsarunas
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
| // linux-x86_64) share a platform and library file name, so platform alone cannot disambiguate them here. | ||
| let library: XCFramework.Library | ||
| if let libraryIdentifier { | ||
| guard let resolved = xcframework.libraries.first(where: { $0.libraryIdentifier == libraryIdentifier && $0.supportedPlatform == plat }) else { |
Collaborator
There was a problem hiding this comment.
No first(where:) please. Use filter(where:) and then emit an error if there are >1 matches.
vsarunas
force-pushed
the
xcf-no-library-found-linux
branch
from
44f4770 to
283f3a0
Compare
vsarunas
requested review from
cmcgee1024,
daveinglis,
jonathanpenn and
rconnell9
as code owners
Collaborator
|
Looks like you accidentally included a bunch of other commits in your branch, can you go ahead and undo that? |
vsarunas
force-pushed
the
xcf-no-library-found-linux
branch
from
76c84f7 to
bbefe99
Compare
Contributor
Author
|
@jakepetroules thanks! Fixed now. |
jakepetroules
approved these changes
Jul 1, 2026
Collaborator
|
@swift-ci test |
vsarunas
force-pushed
the
xcf-no-library-found-linux
branch
from
bbefe99 to
38d9d2a
Compare
Contributor
Author
|
@jakepetroules , could you trigger CI again please? |
Collaborator
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jakepetroules unfortunately one of the polishes in #1310 resulted in a breakage, now that 6.4 builds are available trying to use switch.
The task action fails, since it never supplies an architecture and an early returned was added in findLibrary(), resulting in:
Also fixes an issue with ordering of the x86 vs aarch64; depending on the order the XCF was generated, could have picked the wrong architecture.