Suppress Swift 6 concurrency warning when using XCTWaiter and XCTestExpectation.
#479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stExpectation`. This change annotates the `fulfillment(of:)` overloads so that they won't trigger Swift 6 diagnostics. This is a late-breaking change that has started to [affect](https://forums.swift.org/t/swift-5-10-concurrency-and-xctest/69929) developers using strict concurrency checking with Swift 5.10. Resolves rdar://124966292.
Contributor
Author
|
@swift-ci please test |
grynspan
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
stmontgomery and
suzannaratcliff
Contributor
Author
|
@swift-ci please test |
stmontgomery
approved these changes
Mar 19, 2024
Contributor
Author
|
@swift-ci please test Windows |
briancroom
approved these changes
Mar 20, 2024
Contributor
|
Merging due to known infrastructure problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change annotates the
fulfillment(of:)overloads so that they won't trigger Swift 6 diagnostics. This is a late-breaking change that has started to affect developers using strict concurrency checking with Swift 5.10.Resolves rdar://124966292.