Skip to content

Commit 4706050

Browse files
authored
Merge pull request #1006 from ahoppen/trigger-testing-ready-for-review
Trigger PR testing when PR opened by GitHub Actions is marked as ready for review
2 parents f2b8d75 + 809d50b commit 4706050

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

.github/workflows/pull_request.yml

+7-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Pull request
22

33
on:
44
pull_request:
5-
types: [opened, reopened, synchronize]
5+
types: [opened, reopened, synchronize, ready_for_review]
66

77
concurrency:
88
group: ${{ github.workflow }}-${{ github.ref }}
@@ -12,11 +12,17 @@ jobs:
1212
tests:
1313
name: Test
1414
uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main
15+
# PRs created by GitHub Actions don't kick off further actions (https://github.com/peter-evans/create-pull-request/blob/d57e551ebc1a16dee0b8c9ea6d24dba7627a6e35/docs/concepts-guidelines.md#triggering-further-workflow-runs).
16+
# As a workaround, we mark automerge PRs that are created by GitHub actions as draft and trigger the GitHub actions by marking the PR as ready for review. But we don't want to re-trigger testing this when a normal user's PR is marked as ready for review.
17+
if: (github.event.action != 'ready_for_review') || (github.event.action == 'ready_for_review' && github.event.pull_request.user.login == 'github-actions[bot]')
1518
with:
1619
linux_exclude_swift_versions: "[{\"swift_version\": \"5.8\"}]"
1720
soundness:
1821
name: Soundness
1922
uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main
23+
# PRs created by GitHub Actions don't kick off further actions (https://github.com/peter-evans/create-pull-request/blob/d57e551ebc1a16dee0b8c9ea6d24dba7627a6e35/docs/concepts-guidelines.md#triggering-further-workflow-runs).
24+
# As a workaround, we mark automerge PRs that are created by GitHub actions as draft and trigger the GitHub actions by marking the PR as ready for review. But we don't want to re-trigger testing this when a normal user's PR is marked as ready for review.
25+
if: (github.event.action != 'ready_for_review') || (github.event.action == 'ready_for_review' && github.event.pull_request.user.login == 'github-actions[bot]')
2026
with:
2127
license_header_check_project_name: "Swift.org"
2228
api_breakage_check_allowlist_path: "api-breakages.txt"

0 commit comments

Comments
 (0)