Add support for thread-safe chdir in process spawning

This is needed as a fallback to support Amazon Linux 2 and OpenBSD.

Author: jakepetroules

lib/Basic/Subprocess.cpp

@@ -48,34 +48,21 @@
 #ifdef __APPLE__
 #include <pthread/spawn.h>
 #include "TargetConditionals.h"
-#if !TARGET_OS_IPHONE
-extern "C" {
-  // Provided by System.framework's libsystem_kernel interface
-  extern int __pthread_chdir(const char *path);
-  extern int __pthread_fchdir(int fd);
-}
-
-/// Set the thread specific working directory to the given path.
-int pthread_chdir_np(const char *path)
-{
-  return __pthread_chdir(path);
-}
-
-/// Set the thread specific working directory to that of the given file
-/// descriptor. Passing -1 clears the thread specific working directory,
-/// returning it to the process level working directory.
-int pthread_fchdir_np(int fd)
-{
-  return __pthread_fchdir(fd);
-}
-#endif
 #endif
 
 #ifndef __GLIBC_PREREQ
 #define __GLIBC_PREREQ(maj, min) 0
 #endif
 
 #if !defined(_WIN32) && defined(HAVE_POSIX_SPAWN)
+static bool posix_spawn_file_actions_addchdir_supported() {
+#if (defined(__GLIBC__) && !__GLIBC_PREREQ(2, 29)) || (defined(__OpenBSD__)) || (defined(__ANDROID__) && __ANDROID_API__ < 34) || (defined(__QNX__))
+    return false;
+#else
+    return true;
+#endif
+}
+
 // Implementation mostly copied from _CFPosixSpawnFileActionsChdir in swift-corelibs-foundation
 static int posix_spawn_file_actions_addchdir_polyfill(posix_spawn_file_actions_t * __restrict file_actions,
                                                       const char * __restrict path) {
@@ -775,11 +762,16 @@ void llbuild::basic::spawnProcess(
   posix_spawn_file_actions_t fileActions;
   posix_spawn_file_actions_init(&fileActions);
 
-  bool usePosixSpawnChdirFallback = true;
   const auto workingDir = attr.workingDir.str();
-  if (!workingDir.empty() &&
-      posix_spawn_file_actions_addchdir_polyfill(&fileActions, workingDir.c_str()) != ENOSYS) {
-    usePosixSpawnChdirFallback = false;
+  if (!workingDir.empty()
+      && posix_spawn_file_actions_addchdir_supported()
+      && posix_spawn_file_actions_addchdir_polyfill(&fileActions, workingDir.c_str()) != 0) {
+    auto result = ProcessResult::makeFailed();
+    delegate.processStarted(ctx, handle, pid);
+    delegate.processHadError(ctx, handle, Twine("failed to set the working directory"));
+    delegate.processFinished(ctx, handle, result);
+    completionFn(result);
+    return;
   }
 
 #endif
@@ -865,36 +857,6 @@ void llbuild::basic::spawnProcess(
 
       int result = 0;
 
-      bool workingDirectoryUnsupported = false;
-
-#if !defined(_WIN32)
-      if (usePosixSpawnChdirFallback) {
-#if defined(__APPLE__)
-        thread_local std::string threadWorkingDir;
-
-        if (workingDir.empty()) {
-          if (!threadWorkingDir.empty()) {
-            pthread_fchdir_np(-1);
-            threadWorkingDir.clear();
-          }
-        } else {
-          if (threadWorkingDir != workingDir) {
-            if (pthread_chdir_np(workingDir.c_str()) == -1) {
-              result = errno;
-            } else {
-              threadWorkingDir = workingDir;
-            }
-          }
-        }
-#else
-        if (!workingDir.empty()) {
-          workingDirectoryUnsupported = true;
-          result = -1;
-        }
-#endif // if defined(__APPLE__)
-      }
-#endif // else !defined(_WIN32)
-
       if (result == 0) {
 #if defined(_WIN32)
         auto unicodeEnv = environment.getWindowsEnvp();
@@ -909,10 +871,47 @@ void llbuild::basic::spawnProcess(
                                                   : (LPWSTR)u16Cwd.data(),
             &startupInfo, &processInfo);
 #else
-        result =
+        // For platforms missing posix_spawn_file_actions_addchdir{_np}, we need to fork in order to thread-safely set the wd
+        if (!workingDir.empty()
+            && !posix_spawn_file_actions_addchdir_supported()) {
+          pid_t childPid = fork();
+          switch (childPid) {
+            case -1:
+              // Fail
+              result = errno;
+              break;
+            case 0:
+              // Child
+              pthread_sigmask(SIG_BLOCK, &mostSignals, NULL);
+              if (chdir(workingDir.c_str()) != 0) {
+                _exit(EXIT_FAILURE);
+              }
+              if (attr.connectToConsole) {
+                dup2(STDIN_FILENO, STDIN_FILENO);
+                dup2(STDOUT_FILENO, STDOUT_FILENO);
+                dup2(STDERR_FILENO, STDERR_FILENO);
+              } else {
+                setpgid(0, 0);
+                dup2(open("/dev/null", O_RDONLY, 0), STDIN_FILENO);
+                dup2(outputPipeChildEnd.unsafeDescriptor(), STDOUT_FILENO);
+                dup2(outputPipeChildEnd.unsafeDescriptor(), STDERR_FILENO);
+                close(outputPipeChildEnd.unsafeDescriptor());
+              }
+              if (attr.controlEnabled) {
+                dup2(controlPipeChildEnd.unsafeDescriptor(), controlPipeChildEnd.unsafeDescriptor());
+              }
+              _exit(execve(args[0], const_cast<char**>(args.data()), const_cast<char* const*>(environment.getEnvp())));
+            default:
+              // Parent
+              pid = childPid;
+              break;
+          }
+        } else {
+          result =
             posix_spawn(&pid, args[0], /*file_actions=*/&fileActions,
                         /*attrp=*/&attributes, const_cast<char**>(args.data()),
                         const_cast<char* const*>(environment.getEnvp()));
+        }
 #endif
       }
 
@@ -925,10 +924,7 @@ void llbuild::basic::spawnProcess(
 #endif
         delegate.processHadError(
             ctx, handle,
-            workingDirectoryUnsupported
-                ? Twine("working-directory unsupported on this platform")
-                : Twine("unable to spawn process '") + argsStorage[0] + "' (" + sys::strerror(result) +
-                      ")");
+            Twine("unable to spawn process '") + argsStorage[0] + "' (" + sys::strerror(result) + ")");
         delegate.processFinished(ctx, handle, processResult);
         pid = (llbuild_pid_t)-1;
       } else {