Skip to content

Commit aecde47

Browse files
committed
Revert "Change AsyncProcess stdout/err reads to 4096 instead of Int.max (#9408)"
This reverts commit 41f7eea.
1 parent 37261f4 commit aecde47

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

Sources/Basics/Concurrency/AsyncProcess.swift

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -509,8 +509,7 @@ package final class AsyncProcess {
509509

510510
group.enter()
511511
stdoutPipe.fileHandleForReading.readabilityHandler = { (fh: FileHandle) in
512-
// 4096 is default pipe buffer size so reading in that size seems most efficient and still get output as it available
513-
let data = (try? fh.read(upToCount: 4096)) ?? Data()
512+
let data = (try? fh.read(upToCount: Int.max)) ?? Data()
514513
if data.count == 0 {
515514
stdoutPipe.fileHandleForReading.readabilityHandler = nil
516515
group.leave()
@@ -525,8 +524,7 @@ package final class AsyncProcess {
525524

526525
group.enter()
527526
stderrPipe.fileHandleForReading.readabilityHandler = { (fh: FileHandle) in
528-
// 4096 is default pipe buffer size so reading in that size seems most efficient and still get output as it available
529-
let data = (try? fh.read(upToCount: 4096)) ?? Data()
527+
let data = (try? fh.read(upToCount: Int.max)) ?? Data()
530528
if data.count == 0 {
531529
stderrPipe.fileHandleForReading.readabilityHandler = nil
532530
group.leave()

Utilities/build-using-self

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,6 @@ def main() -> None:
283283
"build",
284284
*global_args,
285285
*BUILD_OVERRIDES,
286-
"--build-tests",
287286
*ignore_args,
288287
*args.additional_build_args.split(" ")
289288
]
@@ -301,7 +300,6 @@ def main() -> None:
301300
*args.additional_run_args.split(" "),
302301
"swift-test",
303302
*global_args,
304-
"--vv",
305303
"--force-resolved-versions",
306304
"--parallel",
307305
"--scratch-path",

0 commit comments

Comments
 (0)