Skip to content

Inconsistent naming of properties for retrieving a generic parameter clause on decl nodes #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AnthonyLatsis opened this issue May 18, 2023 · 3 comments · Fixed by #1686
Closed

Inconsistent naming of properties for retrieving a generic parameter clause on decl nodes #1678

AnthonyLatsis opened this issue May 18, 2023 · 3 comments · Fixed by #1686
Assignees
@TTOzzi
Labels
bug Something isn't working

Comments

@AnthonyLatsis
Copy link
Contributor

Description

All applicable declaration nodes except EnumDeclSyntax use genericParameterClause. The respective property of EnumDeclSyntax is called genericParameters.

Environment

93e905c

Steps to Reproduce

No response
@AnthonyLatsis AnthonyLatsis added the bug Something isn't working label May 18, 2023
@ahoppen
Copy link
Member

ahoppen commented May 18, 2023

Tracked in Apple’s issue tracker as rdar://109533859

@TTOzzi
Copy link
Member

TTOzzi commented May 21, 2023

Hello @ahoppen @kimdv !
Could you please assign me to this task?
I plan to change the genericParameters of EnumDeclSyntax to genericParameterClause uniformly and keep the existing genericParameters with a deprecated annotation.

@TTOzzi
Copy link
Member

TTOzzi commented May 21, 2023

Thank you kimdv! 😃

@TTOzzi TTOzzi mentioned this issue May 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TTOzzi TTOzzi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename genericParameters to genericParameterClause for consistency. TTOzzi/swift-syntax
3 participants
@ahoppen @AnthonyLatsis @TTOzzi