[Evaluator] Temp hack to get more info on underdiagnosed cycle

lorentey · lorentey · commit 0dff899f1fb2 · 2024-02-27T13:46:02.000-08:00
diff --git a/lib/AST/Evaluator.cpp b/lib/AST/Evaluator.cpp
@@ -88,7 +88,7 @@ void Evaluator::finishedRequest(const ActiveRequest &request) {
 }
 
 void Evaluator::diagnoseCycle(const ActiveRequest &request) {
-  if (debugDumpCycles) {
+  if (true /* FIXME(NCG): Temporary hack, remove before flight */ || debugDumpCycles) {
     const auto printIndent = [](llvm::raw_ostream &OS, unsigned indent) {
       OS.indent(indent);
       OS << "`--";
@@ -121,6 +121,7 @@ void Evaluator::diagnoseCycle(const ActiveRequest &request) {
 
     OS << "\n";
   }
+  assert(false) // FIXME(NCG): Temporary hack, remove before flight
 
   request.diagnoseCycle(diags);
   for (const auto &step : llvm::reverse(activeRequests)) {

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ void Evaluator::finishedRequest(const ActiveRequest &request) {`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`void Evaluator::diagnoseCycle(const ActiveRequest &request) {`
`91`		`- if (debugDumpCycles) {`
	`91`	`+ if (true /* FIXME(NCG): Temporary hack, remove before flight */ \|\| debugDumpCycles) {`
`92`	`92`	`const auto printIndent = [](llvm::raw_ostream &OS, unsigned indent) {`
`93`	`93`	`OS.indent(indent);`
`94`	`94`	OS << "`--";
`@@ -121,6 +121,7 @@ void Evaluator::diagnoseCycle(const ActiveRequest &request) {`
`121`	`121`
`122`	`122`	`OS << "\n";`
`123`	`123`	`}`
	`124`	`+ assert(false) // FIXME(NCG): Temporary hack, remove before flight`
`124`	`125`
`125`	`126`	`request.diagnoseCycle(diags);`
`126`	`127`	`for (const auto &step : llvm::reverse(activeRequests)) {`