Skip to content

Commit d6c681e

Browse files
authored
[5.10] Reduce rebuilds when running buildbot_incremental presets in succession (#69168)
We have some configurations in which we run a preset that only builds the compiler, and then a few ones to tests such binary, e.g. ``` buildbot_incremental,tools=RA,stdlib=RD,build buildbot_incremental,tools=RA,stdlib=RD,test=macOS,type=device buildbot_incremental,tools=RA,stdlib=RD,test=iOS,type=simulator buildbot_incremental,tools=RA,stdlib=RD,test=watchOS,type=simulator ``` Contrary to the other presets, in the first preset we did not specify "--lit-args" since it is not necessary -- however that plays a part in the configuration of compiler-rt, causing an unwanted rebuild when that parameter is specified in the following preset. Addresses rdar://116922016 (cherry picked from commit 6cf157e)
1 parent c0694ca commit d6c681e

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

utils/build-presets.ini

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2166,6 +2166,13 @@ build-ninja
21662166
build-swift-stdlib-unittest-extra
21672167
skip-build-benchmarks
21682168

2169+
# This is needed to avoid needless rebuild
2170+
# (in particolar compiler-rt) if we run
2171+
# presets focused on testing like
2172+
# buildbot_incremental,*,test=*
2173+
# after buildbot_incremental,*,build
2174+
lit-args=-v
2175+
21692176
[preset: mixin_buildbot_incremental,test=macOS,type=device]
21702177

21712178
test

0 commit comments

Comments
 (0)