Skip to content

Import thread_local / _Thread_local marked APIs as nonisolated(unsafe) #75820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kateinoigakukun opened this issue Aug 10, 2024 · 0 comments
Open

Import thread_local / _Thread_local marked APIs as nonisolated(unsafe) #75820

kateinoigakukun opened this issue Aug 10, 2024 · 0 comments
Labels
clang importer Area → compiler: The clang importer concurrency Feature: umbrella label for concurrency language features feature A feature request or implementation

Comments

@kateinoigakukun
Copy link
Member

kateinoigakukun commented Aug 10, 2024 •
edited
Loading

Description

Unlike regular global variables, global variables in TLS can be accessed from any actor context without data-race in theory. For example, wasi-libc's errno is defined as a global TLS variable (not a macro unlike other libcs)
ClangImporer should import those global variables with nonisolated(unsafe) attributes to avoid redundant shims

Additional information

No response
@kateinoigakukun kateinoigakukun added clang importer Area → compiler: The clang importer feature A feature request or implementation labels Aug 10, 2024
@kateinoigakukun kateinoigakukun mentioned this issue Aug 10, 2024
Merged
@MaxDesiatov MaxDesiatov added the concurrency Feature: umbrella label for concurrency language features label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang importer Area → compiler: The clang importer concurrency Feature: umbrella label for concurrency language features feature A feature request or implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MaxDesiatov @kateinoigakukun