Skip to content

SourceKit-LSP build failure #79346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hjyamauchi opened this issue Feb 13, 2025 · 3 comments
Closed

SourceKit-LSP build failure #79346

hjyamauchi opened this issue Feb 13, 2025 · 3 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. crash Bug: A crash, i.e., an abnormal termination of software triage needed This issue needs more specific labels

Comments

@hjyamauchi
Copy link
Contributor

hjyamauchi commented Feb 13, 2025

Description

I noticed in our downstream CI

C:\a\swift-build\swift-build\SourceCache\sourcekit-lsp\Sources\LanguageServerProtocolJSONRPC\JSONRPCConnection.swift:370:50: error: type '(RequestID) -> Optional<any ResponseType.Type>' does not conform to the 'Sendable' protocol
368 | 
369 |     // Setup callback for response type.
370 |     decoder.userInfo[.responseTypeCallbackKey] = { (id: RequestID) -> ResponseType.Type? in
    |                                                  |- error: type '(RequestID) -> Optional<any ResponseType.Type>' does not conform to the 'Sendable' protocol
    |                                                  `- note: a function type must be marked '@Sendable' to conform to 'Sendable'
371 |       guard let outstanding = self.outstandingRequests[id] else {
372 |         logger.error("Unknown request for \(id, privacy: .public)")

I guess it's due to the foundation change similar to #79333

Reproduction

Stack dump

No stack

Expected behavior

No build failure

Environment

Windows

Additional information

No response

@hjyamauchi hjyamauchi added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. crash Bug: A crash, i.e., an abnormal termination of software triage needed This issue needs more specific labels labels Feb 13, 2025
@hjyamauchi
Copy link
Contributor Author

CC @compnerd

@compnerd
Copy link
Member

CC: @ahoppen

@ahoppen
Copy link
Member

ahoppen commented Feb 13, 2025

Should be fixed by swiftlang/sourcekit-lsp#1979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. crash Bug: A crash, i.e., an abnormal termination of software triage needed This issue needs more specific labels
Projects
None yet
Development

No branches or pull requests

3 participants