Skip to content

[CMake] Prevent rebuilds of pure swift libraries and executables #66484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

bnbarham
Copy link
Contributor

@bnbarham bnbarham commented Jun 9, 2023

.swiftmodule is listed as an output of pure swift libraries, but it isn't updated if there's been no changes (just like the library and its object files). Add it to the touch hack as well.

Swift executables also list .swiftmodule as an output, even though one isn't generated at all. Add a new POST_BUILD command to touch it regardless.

`.swiftmodule` is listed as an output of pure swift libraries, but it
isn't updated if there's been no changes (just like the library and
its object files). Add it to the touch hack as well.

Swift *executables* also list `.swiftmodule` as an output, even though
one isn't generated at all. Add a new POST_BUILD command to touch it
regardless.
@bnbarham bnbarham requested review from compnerd, rintaro and etcwilde June 9, 2023 03:49
@bnbarham
Copy link
Contributor Author

bnbarham commented Jun 9, 2023

@swift-ci please test

@rintaro
Copy link
Member

rintaro commented Jun 9, 2023

@swift-ci please test Windows

@bnbarham bnbarham merged commit 14282f1 into swiftlang:main Jun 9, 2023
@bnbarham bnbarham deleted the remove-rebuilds branch June 9, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants