Skip to content

AST: Spot fix for AbstractStorageDecl::isResilient() #66494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2023
Merged

AST: Spot fix for AbstractStorageDecl::isResilient() #66494

merged 1 commit into from
Jun 9, 2023

Conversation

slavapestov
Copy link
Contributor

This converges the logic here with NominalTypeDecl::isResilient(). I don't have a test case, but I suspect there's a latent bug here.

@slavapestov slavapestov requested review from hborla and xedin as code owners June 9, 2023 14:15
@slavapestov
Copy link
Contributor Author

@nkcsgexi You implemented @_originallyDefinedIn. Does this look reasonable? Can you suggest a test case?

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

nkcsgexi
nkcsgexi approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Thank you, Slava!

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test Windows

@slavapestov slavapestov merged commit 2e484a1 into swiftlang:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavapestov @nkcsgexi