[Dependency Scanning] Add ClangImporter's mandatory path remaps to dependency scanning query filesystem #81713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
Xazax-hun,
beccadax,
cachemeifyoucan,
egorzhdan,
fahadnayyar,
hborla,
ian-twilightcoder,
j-hui,
slavapestov,
susmonteiro,
xedin and
zoecarver
as code owners
Contributor
Author
|
@swift-ci smoke test |
cachemeifyoucan
approved these changes
May 22, 2025
Contributor
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
Except minor coding style, LGTM.
lib/ClangImporter/ClangImporter.cpp
Outdated
Contributor
There was a problem hiding this comment.
I also prefer if we combine those two functions (or have the new function including the call to the first one).
I guess when caching is on, there is also no need to call the first function.
artemcm
force-pushed
the
ClangRemapsForDepScanQueries
branch
from
ff95101 to
71efcc3
Compare
Contributor
Author
|
@swift-ci smoke test |
…pendency scanning query filesystem On creation, 'ClangImporter' adds overlay modulemap files for non-modular platform libraries (e.g. glibc, libstdc++), which allows Swift code to import and use those libraries. This change adds the same filesystem overlay to dependency scanning queries by applying them to the filesystem instantiated for each depndency scanning worker. Without these overlays EBM builds cannot discover and use non-modular system libraries on non-Darwin platforms. Resolves rdar://151780437
artemcm
force-pushed
the
ClangRemapsForDepScanQueries
branch
from
71efcc3 to
a9e0a58
Compare
Contributor
Author
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On creation,
ClangImporteradds overlay modulemap files for non-modular platform libraries (e.g. glibc, libstdc++), which allows Swift code to import and use those libraries.This change adds the same filesystem overlay to dependency scanning queries by applying them to the filesystem instantiated for each depndency scanning worker. Without these overlays EBM builds cannot discover and use non-modular system libraries on non-Darwin platforms.
Resolves rdar://151780437