Use c++11 for size test (pytorch#3509)

Summary: Pull Request resolved: pytorch#3509

Reviewed By: mergennachin, swolchok

Differential Revision: D57003591

Pulled By: lucylq

fbshipit-source-id: 25f3a311260269761a890d898c6c4381f691cc21

Author: lucylq

runtime/core/portable_type/string_view.h

@@ -79,10 +79,13 @@ class basic_string_view final {
   }
 
   constexpr const_reference at(size_type pos) const {
-    ET_CHECK_MSG(
-        pos >= size_,
-        "string_view::operator[] or string_view::at() out of range");
-    return at_(pos);
+    return (pos >= size_)
+        ? (ET_ASSERT_MESSAGE_EMIT(
+               " (%s): "
+               "string_view::operator[] or string_view::at() out of range",
+               pos >= size_),
+           torch::executor::runtime_abort())
+        : at_(pos);
   }
 
   constexpr const_reference front() const {
@@ -137,9 +140,13 @@ class basic_string_view final {
 
   constexpr basic_string_view substr(size_type pos = 0, size_type count = npos)
       const {
-    ET_CHECK_MSG(
-        pos > size_, "basic_string_view::substr parameter out of bounds.");
-    return substr_(pos, count);
+    return (pos > size_)
+        ? (ET_ASSERT_MESSAGE_EMIT(
+               " (%s): "
+               "basic_string_view::substr parameter out of bounds.",
+               pos > size_),
+           torch::executor::runtime_abort())
+        : substr_(pos, count);
   }
 
   constexpr int compare(basic_string_view rhs) const noexcept {

test/build_size_test.sh

@@ -17,9 +17,9 @@ source "$(dirname "${BASH_SOURCE[0]}")/../.ci/scripts/utils.sh"
 CXX_FLAGS="-Wno-gnu"
 compiler=$(cc --version)
 if [[ $compiler == *"clang"* ]]; then
-  CXX_FLAGS="$CXX_FLAGS -Werror -Wc++17-extensions"
+  CXX_FLAGS="$CXX_FLAGS -Werror -Wc++17-extensions -Wc++14-extensions"
 elif [[ $compiler == *"cc"* ]]; then
-  CXX_FLAGS="$CXX_FLAGS -Werror -Wc++17-compat"
+  CXX_FLAGS="$CXX_FLAGS -Werror -Wc++17-compat -Wc++14-compat"
 else
   echo "Unknown compiler: $compiler"
   exit 1
@@ -31,7 +31,7 @@ cmake_install_executorch_lib() {
   rm -rf cmake-out
 
   retry cmake -DBUCK2="$BUCK2" \
-          -DCMAKE_CXX_STANDARD=14 \
+          -DCMAKE_CXX_STANDARD=11 \
           -DCMAKE_CXX_STANDARD_REQUIRED=ON \
           -DCMAKE_CXX_FLAGS="$CXX_FLAGS" \
           -DCMAKE_INSTALL_PREFIX=cmake-out \