Fix crash when http2 client connects concurrently

Author: matyhtf

ext-src/swoole_http2_client_coro.cc

@@ -119,10 +119,10 @@ class Client {
     }
 
     inline bool is_available() {
-        if (sw_unlikely(!client)) {
+        if (sw_unlikely(!client || !client->is_connect())) {
             swoole_set_last_error(SW_ERROR_CLIENT_NO_CONNECTION);
             zend_update_property_long(
-                swoole_http2_client_coro_ce, SW_Z8_OBJ_P(zobject), ZEND_STRL("errCode"), ECONNRESET);
+                swoole_http2_client_coro_ce, SW_Z8_OBJ_P(zobject), ZEND_STRL("errCode"), SW_ERROR_CLIENT_NO_CONNECTION);
             zend_update_property_string(swoole_http2_client_coro_ce,
                                         SW_Z8_OBJ_P(zobject),
                                         ZEND_STRL("errMsg"),

tests/swoole_http2_client_coro/connect_twice.phpt

@@ -0,0 +1,40 @@
+--TEST--
+swoole_http2_client_coro: connect twice
+--SKIPIF--
+<?php require __DIR__ . '/../include/skipif.inc'; ?>
+--FILE--
+<?php
+require __DIR__ . '/../include/bootstrap.php';
+
+use function Swoole\Coroutine\run;
+use function Swoole\Coroutine\go;
+
+run(function () {
+    $client = new \Swoole\Coroutine\Http2\Client('www.zhihu.com', 443, true);
+    $chan   = new \Swoole\Coroutine\Channel(1);
+    go(function () use ($client, $chan) {
+        $client->connect();
+        $req = new \Swoole\Http2\Request();
+        $req->method = 'GET';
+        $req->path   = '/io?io=' . str_repeat('xxx', 1000);
+        $client->send($req);
+        $chan->push(true);
+        $resp = $client->recv();
+        Assert::eq($resp->statusCode, 200);
+        Assert::contains($resp->data, '知乎');
+        $chan->pop();
+    });
+    go(function () use ($client, $chan) {
+        Assert::eq($client->connect(), false);
+        $req = new \Swoole\Http2\Request();
+        $req->method = 'GET';
+        $req->path   = '/io?io=xxx';
+        $client->send($req);
+        $chan->push(true);
+        Assert::eq($client->recv(), false);
+        $chan->pop();
+    });
+});
+
+?>
+--EXPECT--

tests/swoole_http2_client_coro/error.phpt

@@ -11,9 +11,9 @@ go(function () {
     Assert::false($cli->connect());
     Assert::same($cli->errCode, SOCKET_ETIMEDOUT);
     Assert::false($cli->send(new Swoole\Http2\Request));
-    Assert::same($cli->errCode, SOCKET_ECONNRESET);
+    Assert::same($cli->errCode, SWOOLE_ERROR_CLIENT_NO_CONNECTION);
     Assert::false($cli->recv(1));
-    Assert::same($cli->errCode, SOCKET_ECONNRESET);
+    Assert::same($cli->errCode, SWOOLE_ERROR_CLIENT_NO_CONNECTION);
 });
 Swoole\Event::wait();
 ?>