Skip to content

Commit 1939628

Browse files
authored
Merge pull request #8 from tri-adam/bump-uuid
Bump github.com/satori/go.uuid Module
2 parents c256955 + d1aae9c commit 1939628

5 files changed

Lines changed: 31 additions & 15 deletions

File tree

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/sylabs/sif
33
go 1.15
44

55
require (
6-
github.com/satori/go.uuid v1.2.0
6+
github.com/satori/go.uuid v1.2.1-0.20180404165556-75cca531ea76
77
github.com/spf13/cobra v1.1.3
88
golang.org/x/crypto v0.0.0-20210503195802-e9a32991a82e
99
)

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,8 @@ github.com/rogpeppe/fastuuid v0.0.0-20150106093220-6724a57986af/go.mod h1:XWv6So
140140
github.com/rogpeppe/go-internal v1.3.0/go.mod h1:M8bDsm7K2OlrFYOpmOWEs/qY81heoFRclV5y23lUDJ4=
141141
github.com/russross/blackfriday/v2 v2.0.1/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
142142
github.com/ryanuber/columnize v0.0.0-20160712163229-9b3edd62028f/go.mod h1:sm1tb6uqfes/u+d4ooFouqFdy9/2g9QGwK3SQygK0Ts=
143-
github.com/satori/go.uuid v1.2.0 h1:0uYX9dsZ2yD7q2RtLRtPSdGDWzjeM3TbMJP9utgA0ww=
144-
github.com/satori/go.uuid v1.2.0/go.mod h1:dA0hQrYB0VpLJoorglMZABFdXlWrHn1NEOzdhQKdks0=
143+
github.com/satori/go.uuid v1.2.1-0.20180404165556-75cca531ea76 h1:ofyVTM1w4iyKwaQIlRR6Ip06mXXx5Cnz7a4mTGYq1hE=
144+
github.com/satori/go.uuid v1.2.1-0.20180404165556-75cca531ea76/go.mod h1:dA0hQrYB0VpLJoorglMZABFdXlWrHn1NEOzdhQKdks0=
145145
github.com/sean-/seed v0.0.0-20170313163322-e2103e2c3529/go.mod h1:DxrIzT+xaE7yg65j358z/aeFdxmN0P9QXhEzd20vsDc=
146146
github.com/shurcooL/sanitized_anchor_name v1.0.0/go.mod h1:1NzhyTcUVG4SuEtjjoZeVRXNmyL/1OwPU0+IJeTBvfc=
147147
github.com/sirupsen/logrus v1.2.0/go.mod h1:LxeOpSwHxABJmUn/MG1IvRgCAasNZTLOkJPxbbu5VWo=

internal/app/siftool/modif.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (c) 2018-2019, Sylabs Inc. All rights reserved.
1+
// Copyright (c) 2018-2021, Sylabs Inc. All rights reserved.
22
// Copyright (c) 2018, Divya Cote <divya.cote@gmail.com> All rights reserved.
33
// Copyright (c) 2017, SingularityWare, LLC. All rights reserved.
44
// Copyright (c) 2017, Yannick Cote <yhcote@gmail.com> All rights reserved.
@@ -19,19 +19,20 @@ import (
1919

2020
// New creates a new empty SIF file.
2121
func New(file string) error {
22+
id, err := uuid.NewV4()
23+
if err != nil {
24+
return err
25+
}
26+
2227
cinfo := sif.CreateInfo{
2328
Pathname: file,
2429
Launchstr: sif.HdrLaunch,
2530
Sifversion: sif.HdrVersion,
26-
ID: uuid.NewV4(),
31+
ID: id,
2732
}
2833

29-
_, err := sif.CreateContainer(cinfo)
30-
if err != nil {
31-
return err
32-
}
33-
34-
return nil
34+
_, err = sif.CreateContainer(cinfo)
35+
return err
3536
}
3637

3738
// AddOptions contains the options when adding a section to a SIF file.

pkg/integrity/testdata/gen_sifs.go

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
// Copyright (c) 2020-2021, Sylabs Inc. All rights reserved.
2+
// This software is licensed under a 3-clause BSD license. Please consult the LICENSE.md file
3+
// distributed with the sources of this project regarding your rights to use or distribute this
4+
// software.
5+
16
package main
27

38
import (
@@ -13,15 +18,20 @@ import (
1318
)
1419

1520
func createImage(path string, dis []sif.DescriptorInput) error {
21+
id, err := uuid.NewV4()
22+
if err != nil {
23+
return err
24+
}
25+
1626
ci := sif.CreateInfo{
1727
Pathname: path,
1828
Launchstr: sif.HdrLaunch,
1929
Sifversion: sif.HdrVersion,
20-
ID: uuid.NewV4(),
30+
ID: id,
2131
InputDescr: dis,
2232
}
2333

24-
_, err := sif.CreateContainer(ci)
34+
_, err = sif.CreateContainer(ci)
2535
return err
2636
}
2737

pkg/sif/create_test.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (c) 2018-2020, Sylabs Inc. All rights reserved.
1+
// Copyright (c) 2018-2021, Sylabs Inc. All rights reserved.
22
// This software is licensed under a 3-clause BSD license. Please consult the
33
// LICENSE file distributed with the sources of this project regarding your
44
// rights to use or distribute this software.
@@ -60,12 +60,17 @@ func TestDataStructs(t *testing.T) {
6060
}
6161

6262
func TestCreateContainer(t *testing.T) {
63+
id, err := uuid.NewV4()
64+
if err != nil {
65+
t.Fatal(err)
66+
}
67+
6368
// general info for the new SIF file creation
6469
cinfo := CreateInfo{
6570
Pathname: "testdata/testcontainer.sif",
6671
Launchstr: HdrLaunch,
6772
Sifversion: HdrVersion,
68-
ID: uuid.NewV4(),
73+
ID: id,
6974
}
7075

7176
// test container creation without any input descriptors

0 commit comments

Comments
 (0)