Skip to content

Commit 00a67d5

Browse files
committed
Improve accessibility and design
1 parent a5a6795 commit 00a67d5

File tree

5 files changed

+16
-15
lines changed

5 files changed

+16
-15
lines changed

assets/styles/app.scss

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ header {
199199
border-radius: 4px;
200200
color: $gray-900;
201201
display: flex;
202+
justify-content: space-between;
202203
padding: 10px 20px;
203204

204205
small {
@@ -208,7 +209,7 @@ header {
208209
font-size: 14px;
209210
font-weight: bold;
210211
line-height: 1.1;
211-
margin-inline-end: 10px;
212+
margin-inline-start: 10px;
212213
min-width: 26px;
213214
padding: 2px 6px;
214215
text-align: center;
@@ -217,12 +218,12 @@ header {
217218
}
218219

219220
&:hover a {
220-
outline: 3px solid #f7c36e;
221-
outline-offset: 2px;
221+
outline: 3px solid #18bc9c;
222+
outline-offset: -5px;
222223

223224
small {
224-
background: #2c3e50;
225-
border-color: #2c3e50;
225+
background: #18bc9c;
226+
border-color: #18bc9c;
226227
color: #fff;
227228
}
228229
}

public/build/app.493ae962.css renamed to public/build/app.e7ad18f4.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/build/entrypoints.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
],
1010
"css": [
1111
"/build/42.76194c5a.css",
12-
"/build/app.493ae962.css"
12+
"/build/app.e7ad18f4.css"
1313
]
1414
},
1515
"admin": {
@@ -30,7 +30,7 @@
3030
"/build/42.5aced7b3.js": "sha384-wqPte8ueaLTZwKszn5yK/iS5GuSBYNuwZtNs5G6BWGzGI17VoFv2lXNHwQbeTCWh",
3131
"/build/app.8d5ecae9.js": "sha384-2UhLzumRcZ9rIylCmaGHxKCG1IFSEarrvMs4G6qEzE0Hl0lnrNc+e9jB8gZijjaf",
3232
"/build/42.76194c5a.css": "sha384-PoA8WLGz/za3OOW7qjoDiv5f8mBVtREO35Z70PFH8PVIdu1+nWVUEetA6Q1o6DhV",
33-
"/build/app.493ae962.css": "sha384-Ae1HWNmMAMvR0KVZTirvCPKrqUDIlzfDUgc4yLGuRJ01hy8MkNcOXlEgPLgy+YOW",
33+
"/build/app.e7ad18f4.css": "sha384-AX8sd4a5GkOjaVooLq9t+zDI/fqugWjeU5OP+fHkycws0R/G5zaM8UZ4qx32gTNi",
3434
"/build/384.af623ff4.js": "sha384-DTkf7hVvZ08YUepoH5wzP+thJm6maRzLe8KxUgIc2OajdJkoSDct0pJMEPYcEEeF",
3535
"/build/admin.747eb0c9.js": "sha384-vDe3FhM5HnWbM4nEdbmSv8AB5n/PfPJv0y0Goloka7w6jppc6di5LpKD1A252aFg",
3636
"/build/admin.2b1a6c83.css": "sha384-ikQwASTRPK0sjWtW//EXsUjqkjNxc2Yndtt0m5a/I/qE+qEoikXP5ailZKDaqtN9"

public/build/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"build/app.css": "/build/app.493ae962.css",
2+
"build/app.css": "/build/app.e7ad18f4.css",
33
"build/app.js": "/build/app.8d5ecae9.js",
44
"build/admin.css": "/build/admin.2b1a6c83.css",
55
"build/admin.js": "/build/admin.747eb0c9.js",

templates/base.html.twig

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,24 +96,24 @@
9696
<div class="modal-lg modal-dialog modal-dialog-centered">
9797
<div class="modal-content">
9898
<div class="modal-header">
99-
<h5 class="modal-title">
99+
<p class="modal-title" lang="en">
100100
{# display this title always in English to make the language selector easier to use #}
101101
Choose your language
102-
</h5>
102+
</p>
103103
<button type="button" class="close" data-dismiss="modal" aria-label="Close">
104104
<span aria-hidden="true">&times;</span>
105105
</button>
106106
</div>
107107

108108
<div class="modal-body">
109-
<ul class="locales" role="menu" aria-labelledby="locales">
109+
<ul class="locales">
110110
{% for locale in locales() %}
111111
{% set is_active = app.request.locale == locale.code %}
112112
{% set is_rtl = locale.code in ['ar', 'fa', 'he'] %}
113-
<li aria-checked="{{ is_active ? 'true' : 'false' }}" class="{{ is_active ? 'active' }} {{ is_rtl ? 'rtl' }}" role="menuitem" translate="no">
114-
<a class="stretched-link" href="{{ path(app.request.get('_route', 'blog_index'), app.request.get('_route_params', [])|merge({_locale: locale.code})) }}">
115-
<small>{{ locale.code[0:2] }}</small>
113+
<li class="{{ is_active ? 'active' }} {{ is_rtl ? 'rtl' }}" translate="no">
114+
<a class="stretched-link" lang="{{ locale.code }}" hreflang="{{ locale.code }}" href="{{ path(app.request.get('_route', 'blog_index'), app.request.get('_route_params', [])|merge({_locale: locale.code})) }}">
116115
{{ locale.name|capitalize }}
116+
<small>{{ locale.code }}</small>
117117
</a>
118118
</li>
119119
{% endfor %}

0 commit comments

Comments
 (0)