Skip to content

Commit 1c1ff08

Browse files
committed
bug #1138 Fix search query (jkufner)
This PR was squashed before being merged into the master branch. Discussion ---------- Fix search query When visiting `http://localhost:8000/cs/blog/search?q=de` directly, the search is not triggered automatically. This PR triggers the search on page load and passes the provided query argument to the input field. Commits ------- de60ace Fix search query
2 parents e1dffb2 + de60ace commit 1c1ff08

File tree

5 files changed

+12
-8
lines changed

5 files changed

+12
-8
lines changed

assets/js/search.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
import './jquery.instantSearch.js';
22

33
$(function() {
4-
$('.search-field').instantSearch({
5-
delay: 100,
6-
});
4+
$('.search-field')
5+
.instantSearch({
6+
delay: 100,
7+
})
8+
.keyup();
79
});

public/build/entrypoints.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@
4747
"/build/login.js": "sha384-w5qwGnj2mp4pazKe9KGCQU+FR1n/717WouCp594UxY7HHGLafcGrZ9mrFR68V6oe",
4848
"/build/admin.js": "sha384-nicrzvXIMGjWH5/pdimaGfVfn2LB/i2RxpKGp5XiWyspyQj6VmrfxlybhN5W+ksw",
4949
"/build/admin.css": "sha384-ilLLAgcQxfeIVl6jV3AsZ2jmrWwgECQptl9HYwqc2NpYuTl6FEW46DBpDk5Q76sp",
50-
"/build/search.js": "sha384-psGgj2E6N5ueWFmL86ZDUGX8QJNJM9Uoy//YLzvlW8/x6v1zn7zsgMIFVFEjgsC2"
50+
"/build/search.js": "sha384-mmhQLZ7DRLI71dJilhS384iek0VyZaGARlhbLwwNgjsBtMlzb58H1LZO0MWe5w+b"
5151
}
5252
}

public/build/search.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Controller/BlogController.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,12 +144,13 @@ public function commentForm(Post $post): Response
144144
*/
145145
public function search(Request $request, PostRepository $posts): Response
146146
{
147+
$query = $request->query->get('q', '');
148+
$limit = $request->query->get('l', 10);
149+
147150
if (!$request->isXmlHttpRequest()) {
148-
return $this->render('blog/search.html.twig');
151+
return $this->render('blog/search.html.twig', ['query' => $query]);
149152
}
150153

151-
$query = $request->query->get('q', '');
152-
$limit = $request->query->get('l', 10);
153154
$foundPosts = $posts->findBySearchQuery($query, $limit);
154155

155156
$results = [];

templates/blog/search.html.twig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
class="form-control search-field"
1515
placeholder="{{ 'post.search_for'|trans }}"
1616
autocomplete="off"
17+
value="{{ query }}"
1718
autofocus
1819
data-no-results-message="{{ 'post.search_no_results'|trans }}"
1920
>

0 commit comments

Comments
 (0)