minor #238 Fixing details (yceruto)

This PR was squashed before being merged into the master branch (closes #238).

Discussion
----------

Fixing details

* Fixing imports (unused or missing).
* Adding type hinting.
* Fixed variable definition.

Commits
-------

6702b63 Fixing details

Author: javiereguiluz

src/AppBundle/Command/AddUserCommand.php

@@ -195,7 +195,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $user->setPassword($encodedPassword);
 
         $this->entityManager->persist($user);
-        $this->entityManager->flush($user);
+        $this->entityManager->flush();
 
         $output->writeln('');
         $output->writeln(sprintf('[OK] %s was successfully created: %s (%s)', $isAdmin ? 'Administrator user' : 'User', $user->getUsername(), $user->getEmail()));

src/AppBundle/Command/DeleteUserCommand.php

@@ -11,10 +11,10 @@
 
 namespace AppBundle\Command;
 
+use AppBundle\Entity\User;
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Question\Question;
 use Doctrine\Common\Persistence\ObjectManager;
@@ -109,6 +109,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $this->usernameValidator($username);
 
         $repository = $this->entityManager->getRepository('AppBundle:User');
+        /** @var User $user */
         $user = $repository->findOneByUsername($username);
 
         if (null === $user) {

src/AppBundle/Command/ListUsersCommand.php

@@ -11,6 +11,8 @@
 
 namespace AppBundle\Command;
 
+use AppBundle\Entity\User;
+use Doctrine\Common\Persistence\ObjectManager;
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Input\InputInterface;
@@ -88,7 +90,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $users = $this->entityManager->getRepository('AppBundle:User')->findBy(array(), array('id' => 'DESC'), $maxResults);
 
         // Doctrine query returns an array of objects and we need an array of plain arrays
-        $usersAsPlainArrays = array_map(function ($user) {
+        $usersAsPlainArrays = array_map(function (User $user) {
             return array($user->getId(), $user->getUsername(), $user->getEmail(), implode(', ', $user->getRoles()));
         }, $users);
 

src/AppBundle/Repository/PostRepository.php

@@ -12,7 +12,6 @@
 namespace AppBundle\Repository;
 
 use Doctrine\ORM\EntityRepository;
-use AppBundle\Entity\Post;
 
 /**
  * This custom Doctrine repository contains some methods which are useful when

src/AppBundle/Twig/AppExtension.php

@@ -87,6 +87,7 @@ public function getLocales()
     {
         $localeCodes = explode('|', $this->locales);
 
+        $locales = array();
         foreach ($localeCodes as $localeCode) {
             $locales[] = array('code' => $localeCode, 'name' => Intl::getLocaleBundle()->getLocaleName($localeCode, $localeCode));
         }