Refactor to use in the post filtering feature

Author: voronkovich

app/config/services.yml

@@ -7,6 +7,9 @@ services:
     markdown:
         class: AppBundle\Utils\Markdown
 
+    term_splitter:
+        class: AppBundle\Utils\TermSplitter
+
     # These are the Twig extensions that create new filters and functions for
     # using them in the templates
     app.twig.app_extension:

src/AppBundle/Controller/BlogController.php

@@ -128,26 +128,21 @@ public function commentFormAction(Post $post)
      */
     public function searchAction(Request $request)
     {
-        $query = $request->query->get('q', '');
-
-        // Sanitizing the query: removes all non-alphanumeric characters except whitespaces
-        $query = preg_replace('/[^[:alnum:] ]/', '', trim(preg_replace('/[[:space:]]+/', ' ', $query)));
+        $posts = array();
 
-        // Splits the query into terms and removes all terms which
-        // length is less than 2
-        $terms = array_unique(explode(' ', strtolower($query)));
-        $terms = array_filter($terms, function($term) {
-            return 2 <= strlen($term);
-        });
+        $query = $request->query->get('q', '');
 
-        $posts = array();
+        $terms = $this->get('term_splitter')->splitIntoTerms($query, 2);
 
         if (!empty($terms)) {
             $posts = $this
                 ->getDoctrine()
-                ->getManager()
                 ->getRepository('AppBundle:Post')
-                ->findByTerms($terms)
+                ->createQueryBuilderForTerms($terms, 'p')
+                ->orderBy('p.publishedAt', 'DESC')
+                ->setMaxResults(10)
+                ->getQuery()
+                ->getResult()
             ;
         }
 
@@ -156,7 +151,7 @@ public function searchAction(Request $request)
         foreach ($posts as $post) {
             array_push($results, array(
                 'result' => htmlspecialchars($post->getTitle()),
-                'url' => $this->generateUrl('blog_post', array('slug' => $post->getSlug())),
+                'url'    => $this->generateUrl('blog_post', array('slug' => $post->getSlug())),
             ));
         }
 

src/AppBundle/Repository/PostRepository.php

@@ -12,7 +12,6 @@
 namespace AppBundle\Repository;
 
 use Doctrine\ORM\EntityRepository;
-use AppBundle\Entity\Post;
 
 /**
  * This custom Doctrine repository contains some methods which are useful when
@@ -42,21 +41,17 @@ public function findLatest()
         $this->queryLatest()->getResult();
     }
 
-    public function findByTerms(array $terms, $limit = Post::NUM_ITEMS)
+    public function createQueryBuilderForTerms(array $terms, $alias = 'p')
     {
-        $queryBuilder = $this->createQueryBuilder('p');
+        $queryBuilder = $this->createQueryBuilder($alias);
 
         foreach ($terms as $key => $term) {
             $queryBuilder
-                ->orWhere('p.title LIKE :t_' . $key)
+                ->orWhere(sprintf('%s.title LIKE :t_%s', $alias, $key))
                 ->setParameter('t_' . $key , '%' . $term . '%')
             ;
         }
 
-        return $queryBuilder
-            ->orderBy('p.publishedAt', 'DESC')
-            ->setMaxResults($limit)
-            ->getQuery()
-            ->getResult();
+        return $queryBuilder;
     }
 }

src/AppBundle/Utils/TermSplitter.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace AppBundle\Utils;
+
+/**
+ * @author Oleg Voronkovich <oleg-voronkovich@yandex.ru>
+ */
+class TermSplitter
+{
+    /**
+     * Splits a given string into terms.
+     *
+     * @param string $string
+     * @param int $minTermLength
+     *
+     * @return array
+     */
+    public function splitIntoTerms($string, $minTermLength = 2)
+    {
+        // Sanitizing the string: removes all non-alphanumeric characters except whitespaces
+        $string = preg_replace('/[^[:alnum:] ]/', '', trim(preg_replace('/[[:space:]]+/', ' ', $string)));
+
+        // Splits the string into terms and removes all terms which
+        // length is less than $minTermLength
+        $terms = array_unique(explode(' ', strtolower($string)));
+        $terms = array_filter($terms, function($term) use ($minTermLength) {
+            return $minTermLength <= strlen($term);
+        });
+
+        return $terms;
+    }
+}