Skip to content

Commit 8cb63a5

Browse files
committed
minor #1450 Remove Sass from custom CSS files (javiereguiluz)
This PR was squashed before being merged into the main branch. Discussion ---------- Remove Sass from custom CSS files This is mentioned by `@weaverryan` in #1449. We don't really use any Sass feature (except nesting and some variables). I've replaced Sass variables by CSS custom properties ... and removed the nesting by flattening all styles (we can readd nesting soon when native support is a big bigger than today: https://caniuse.com/?search=nesting). **Ryan**, if you agree on this, can we just merge it and then you rebase your PR? Thanks! Commits ------- 691859e Remove Sass from custom CSS files
2 parents 701f9d0 + 691859e commit 8cb63a5

File tree

7 files changed

+234
-237
lines changed

7 files changed

+234
-237
lines changed

assets/styles/admin.scss

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
// @import "~eonasdan-bootstrap-datetimepicker/src/sass/bootstrap-datetimepicker-build.scss";
33
@import "bootstrap-tagsinput.scss";
44

5+
:root {
6+
--blue: #007bff;
7+
}
8+
59
/* Page: 'Backend post index'
610
------------------------------------------------------------------------- */
711
body#admin_post_index .item-actions {
@@ -27,9 +31,8 @@ body#admin_post_show .post-tags .label-default i {
2731

2832
.form-control {
2933
border-width: .125rem;
30-
31-
&:focus {
32-
color: $blue;
33-
box-shadow: none;
34-
}
35-
}
34+
}
35+
.form-control:focus {
36+
color: var(--blue);
37+
box-shadow: none;
38+
}

0 commit comments

Comments
 (0)