Skip to content

Manage application assets with the new Symfony asset manager #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiereguiluz opened this issue Jun 11, 2017 · 6 comments
Closed

Manage application assets with the new Symfony asset manager #585

javiereguiluz opened this issue Jun 11, 2017 · 6 comments
Assignees

Comments

@javiereguiluz
Copy link
Member

Next week Ryan will publish his new project to manage web assets in Symfony applications. I propose to start using it in the Symfony Demo right away. Although it's new, it's pretty stable and it has been tested in several real Symfony apps.

The only thing to keep in mind is that the generated CSS and JS files must be committed to the repository to keep our promise that this app works out of the box without configuring anything or executing any command.

I'll take care of this issue because I have already worked with this package, so hopefully I can integrate it quickly. Thanks!

@stof
Copy link
Member

stof commented Jun 13, 2017

what is this asset manager doing ?

@javiereguiluz
Copy link
Member Author

I don't understand your comment ... but OK, it's not an asset manager ... is a helper for the real asset manager, which is Webpack 😁

@stof
Copy link
Member

stof commented Jun 13, 2017

Well, you say "use the new asset manager". Having some kind of description of what this project does would be a good idea when you open an issue asking to use it (and unlike Encore, I don't have pre-release access to it, so I need to ask when you tease us)

@javiereguiluz
Copy link
Member Author

@stof there's been a HUGE misunderstanding between us: I'm talking about Encore in this PR, not about another unannounced tool 😄 I didn't want to mention the real name (Webpack Encore) before Ryan unveiled it ... so I said "asset manager" ... but that's wrong, because Encore is "a Webpack manager".

@stof
Copy link
Member

stof commented Jun 14, 2017

hmm, I missed the fact that this issue was opened before the release of Encore. I saw the issue after it (when reviewing the PR adding Encore).

I suggest closing this issue then, as the PR is merged (unless you want to polish the documentation about using Encore in the demo first)

@javiereguiluz
Copy link
Member Author

Closing it as fixed by #589 and #593.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants