From e6349dc170d282473101ddbbdf4ded24539ec14b Mon Sep 17 00:00:00 2001 From: Javier Eguiluz Date: Thu, 4 Oct 2018 15:28:31 +0200 Subject: [PATCH] Fixed the handling of flash messages --- templates/default/_flash_messages.html.twig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/templates/default/_flash_messages.html.twig b/templates/default/_flash_messages.html.twig index 8d859f52e..1ebb091f9 100644 --- a/templates/default/_flash_messages.html.twig +++ b/templates/default/_flash_messages.html.twig @@ -5,15 +5,16 @@ A common practice to better distinguish between templates and fragments is to prefix fragments with an underscore. That's why this template is called '_flash_messages.html.twig' instead of 'flash_messages.html.twig' +#} - We check if we have session before reading flashes as it otherwise triggers session start: +{# + The request method check is needed to prevent starting the session when looking for "flash messages": https://symfony.com/doc/current/session/avoid_session_start.html TIP: With FOSHttpCache you can also adapt this to make it cache safe: https://foshttpcachebundle.readthedocs.io/en/latest/features/helpers/flash-message.html #} - -{% if app.request.hasPreviousSession %} +{% if app.request.method == 'POST' %}
{% for type, messages in app.flashes %} {% for message in messages %}