add return types

Author: jrushlow

src/Maker/MakeEntity.php

@@ -337,7 +337,7 @@ public function configureDependencies(DependencyBuilder $dependencies, InputInte
         ORMDependencyBuilder::buildDependencies($dependencies);
     }
 
-    private function askForNextField(ConsoleStyle $io, array $fields, string $entityClass, bool $isFirstField)
+    private function askForNextField(ConsoleStyle $io, array $fields, string $entityClass, bool $isFirstField): EntityRelation|array|null
     {
         $io->writeln('');
 
@@ -475,7 +475,7 @@ private function printAvailableTypes(ConsoleStyle $io): void
             ],
         ];
 
-        $printSection = function (array $sectionTypes) use ($io, &$allTypes) {
+        $printSection = static function (array $sectionTypes) use ($io, &$allTypes) {
             foreach ($sectionTypes as $mainType => $subTypes) {
                 unset($allTypes[$mainType]);
                 $line = sprintf('  * <comment>%s</comment>', $mainType);
@@ -527,7 +527,7 @@ private function createEntityClassQuestion(string $questionText): Question
         return $question;
     }
 
-    private function askRelationDetails(ConsoleStyle $io, string $generatedEntityClass, string $type, string $newFieldName)
+    private function askRelationDetails(ConsoleStyle $io, string $generatedEntityClass, string $type, string $newFieldName): EntityRelation
     {
         // ask the targetEntity
         $targetEntityClass = null;
@@ -573,15 +573,15 @@ function ($name) use ($targetClass) {
             );
         };
 
-        $askIsNullable = function (string $propertyName, string $targetClass) use ($io) {
+        $askIsNullable = static function (string $propertyName, string $targetClass) use ($io) {
             return $io->confirm(sprintf(
                 'Is the <comment>%s</comment>.<comment>%s</comment> property allowed to be null (nullable)?',
                 Str::getShortClassName($targetClass),
                 $propertyName
             ));
         };
 
-        $askOrphanRemoval = function (string $owningClass, string $inverseClass) use ($io) {
+        $askOrphanRemoval = static function (string $owningClass, string $inverseClass) use ($io) {
             $io->text([
                 'Do you want to activate <comment>orphanRemoval</comment> on your relationship?',
                 sprintf(
@@ -844,27 +844,27 @@ private function getPropertyNames(string $class): array
 
         $reflClass = new \ReflectionClass($class);
 
-        return array_map(function (\ReflectionProperty $prop) {
+        return array_map(static function (\ReflectionProperty $prop) {
             return $prop->getName();
         }, $reflClass->getProperties());
     }
 
-    /** @legacy Drop when Annotations are no longer supported */
-    private function doesEntityUseAnnotationMapping(string $className): bool
-    {
-        if (!class_exists($className)) {
-            $otherClassMetadatas = $this->doctrineHelper->getMetadata(Str::getNamespace($className).'\\', true);
-
-            // if we have no metadata, we should assume this is the first class being mapped
-            if (empty($otherClassMetadatas)) {
-                return false;
-            }
-
-            $className = reset($otherClassMetadatas)->getName();
-        }
-
-        return $this->doctrineHelper->isClassAnnotated($className);
-    }
+//    /** @legacy Drop when Annotations are no longer supported */
+//    private function doesEntityUseAnnotationMapping(string $className): bool
+//    {
+//        if (!class_exists($className)) {
+//            $otherClassMetadatas = $this->doctrineHelper->getMetadata(Str::getNamespace($className).'\\', true);
+//
+//            // if we have no metadata, we should assume this is the first class being mapped
+//            if (empty($otherClassMetadatas)) {
+//                return false;
+//            }
+//
+//            $className = reset($otherClassMetadatas)->getName();
+//        }
+//
+//        return $this->doctrineHelper->isClassAnnotated($className);
+//    }
 
     /** @legacy Drop when Annotations are no longer supported */
     private function doesEntityUseAttributeMapping(string $className): bool