Skip to content

Scheduler file in wrong directory #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chapterjason opened this issue Apr 25, 2025 · 4 comments
Open

Scheduler file in wrong directory #1406

chapterjason opened this issue Apr 25, 2025 · 4 comments

Comments

@chapterjason
Copy link

Hello,

I just ran a Composer update and noticed that PR #1403 places the scheduler file beside the kernel file in the root src directory. Shouldn’t it reside in the Scheduler subdirectory?

@OskarStark
Copy link
Contributor

Friendly ping @kbond

@kbond
Copy link
Member

kbond commented Apr 26, 2025

I did specifically choose src/Scheduler.php as I feel it's super rare that you'd have multiple schedules. To have a Scheduler dir for a, 99% of the time, single file, feels yucky to me. It's possible to have multiple Kernel's but we don't have a Kernel dir.

This all being said, I don't feel super strongly about this. I personally prefer a flatter dir structure.

@fabpot
Copy link
Member

fabpot commented Apr 26, 2025

I tend to agree with @kbond

@chapterjason
Copy link
Author

I understand that. I created the "Schedule" with the maker command and subsequently renamed it to DefaultScheduleProvider, as this more accurately describes its purpose.

For me, it's simply about maintaining consistency across Symfony concepts (for example: Controller, Message, MessageHandler, etc.).

Beyond that, it's just a recipe—feel free to modify it as needed. I'm fine with that; I was only confused by the lack of any explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants