Skip to content

Commit aa49651

Browse files
committed
minor #116 Remove Babel (which was not really necessary), replace it by acorn if needed, close #105 (Kocal)
This PR was merged into the main branch. Discussion ---------- Remove Babel (which was not really necessary), replace it by acorn if needed, close #105 Babel configuration files `.babel.rc` and `babel.config.js` were not used (anymore), ``@babel`/parser` can be replaced by `acorn` that we already use, so we can remove Babel and remove ~120 devDependencies: - before: ``` Progress: resolved 1, reused 0, downloaded 0, added 0 Progress: resolved 11[8](https://github.com/symfony/stimulus-bridge/actions/runs/13026638540/job/36336794852?pr=115#step:6:9), reused 1, downloaded 99, added 0 Progress: resolved 284, reused 1, downloaded 243, added 0 Packages: +360 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Progress: resolved 423, reused 1, downloaded 364, added 360, done .../[email protected]/node_modules/esbuild postinstall$ node install.js .../node_modules/`@biomejs`/biome postinstall$ node scripts/postinstall.js .../[email protected]/node_modules/esbuild postinstall: Done .../node_modules/`@biomejs`/biome postinstall: Done dependencies: + `@hotwired`/stimulus-webpack-helpers 1.0.1 + `@types`/webpack-env 1.18.8 + loader-utils 3.3.1 + schema-utils 4.3.0 devDependencies: + `@babel`/core 7.26.7 + `@babel`/parser 7.26.7 + `@babel`/preset-env 7.26.7 + `@babel`/preset-typescript 7.26.0 + `@babel`/types 7.26.7 + `@biomejs`/biome 1.[9](https://github.com/symfony/stimulus-bridge/actions/runs/13026638540/job/36336794852?pr=115#step:6:10).4 + `@hotwired`/stimulus 3.2.2 + `@rollup`/plugin-typescript 12.1.2 + `@symfony`/mock-module 1.0.0 + `@testing`-library/jest-dom 6.6.3 + acorn 8.14.0 + jsdom 26.0.0 + json5 2.2.3 + rolldown 1.0.0-beta.3 + tslib 2.8.1 + typescript 4.9.5 (5.7.3 is available) + vitest 3.0.4 + webpack 5.97.1 + webpack-cli 5.1.4 (6.0.1 is available)  WARN  Issues with peer dependencies found . └─┬ valibot 1.0.0-beta.[12](https://github.com/symfony/stimulus-bridge/actions/runs/13026638540/job/36336794852?pr=115#step:6:13) └── ✕ unmet peer typescript@>=5: found 4.9.5 Done in 3.9s ``` - after: ``` Progress: resolved 1, reused 0, downloaded 0, added 0 Progress: resolved 68, reused 1, downloaded 27, added 0 Progress: resolved 210, reused 1, downloaded 173, added 0 Packages: +241 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Progress: resolved 304, reused 1, downloaded 245, added 241, done .../node_modules/`@biomejs`/biome postinstall$ node scripts/postinstall.js .../[email protected]/node_modules/esbuild postinstall$ node install.js .../node_modules/`@biomejs`/biome postinstall: Done .../[email protected]/node_modules/esbuild postinstall: Done dependencies: + `@hotwired`/stimulus-webpack-helpers 1.0.1 + `@types`/webpack-env 1.18.8 + loader-utils 3.3.1 + schema-utils 4.3.0 devDependencies: + `@biomejs`/biome 1.[9](https://github.com/symfony/stimulus-bridge/actions/runs/13026994439/job/36337823223?pr=116#step:6:9).4 + `@hotwired`/stimulus 3.2.2 + `@rollup`/plugin-typescript 12.1.2 + `@symfony`/mock-module 1.0.0 + `@testing`-library/jest-dom 6.6.3 + acorn 8.14.0 + jsdom 26.0.0 + json5 2.2.3 + rolldown 1.0.0-beta.3 + tslib 2.8.1 + typescript 4.9.5 (5.7.3 is available) + vitest 3.0.4 + webpack 5.97.1 + webpack-cli 5.1.4 (6.0.1 is available)  WARN  Issues with peer dependencies found . └─┬ valibot 1.0.0-beta.[12](https://github.com/symfony/stimulus-bridge/actions/runs/13026994439/job/36337823223?pr=116#step:6:12) └── ✕ unmet peer typescript@>=5: found 4.9.5 Done in 3.5s ``` Commits ------- 77e9506 Remove Babel (which was not really necessary), replace it by acorn if needed, close #105
2 parents 0a416c2 + 77e9506 commit aa49651

File tree

6 files changed

+180
-1559
lines changed

6 files changed

+180
-1559
lines changed

.babelrc

Lines changed: 0 additions & 3 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
* Migrate from [Rollup](https://rollupjs.org/) to [Rolldown](https://rolldown.rs/) by @Kocal in https://github.com/symfony/stimulus-bridge/pull/99
2424
* Migrate from [Yarn](https://yarnpkg.com/) to [pnpm](https://pnpm.io/) by @Kocal in https://github.com/symfony/stimulus-bridge/pull/108
2525
* Migrate from [Jest](https://jestjs.io/) to [Vitest](https://vitest.dev/) by @Kocal in https://github.com/symfony/stimulus-bridge/pull/115
26+
* Migrate or remove [Babel](https://babeljs.io/) in favor of [Acorn](https://github.com/acornjs/acorn) by @Kocal in https://github.com/symfony/stimulus-bridge/pull/116
2627

2728
## 3.3.3
2829

babel.config.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

package.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,6 @@
2727
"schema-utils": "^3.0.0 || ^4.0.0"
2828
},
2929
"devDependencies": {
30-
"@babel/core": "^7.22.0",
31-
"@babel/parser": "^7.26.7",
32-
"@babel/preset-env": "^7.22.0",
33-
"@babel/preset-typescript": "^7.22.0",
34-
"@babel/types": "^7.26.7",
3530
"@biomejs/biome": "^1.9.4",
3631
"@hotwired/stimulus": "^3.0",
3732
"@rollup/plugin-typescript": "^12.1.2",

0 commit comments

Comments
 (0)