Skip to content

[META] Symfony Security issues #15908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
19 of 21 tasks
javiereguiluz opened this issue Oct 8, 2021 · 10 comments
Closed
19 of 21 tasks

[META] Symfony Security issues #15908

javiereguiluz opened this issue Oct 8, 2021 · 10 comments
Labels
Milestone

Comments

@javiereguiluz
Copy link
Member

javiereguiluz commented Oct 8, 2021

In #15503 we're revamping Security docs. This meta-issue lists all security-related issues that are still pending. That way we can quickly check them and see if we've already fixed them in the new docs or even if we can ignore them because they are not relevant for docs:

@javiereguiluz javiereguiluz added this to the 5.4 milestone Oct 8, 2021
This was referenced Oct 8, 2021
@wouterj
Copy link
Member

wouterj commented Oct 10, 2021

Thanks Javier! I've checked some tasks that I believe don't need any documentation change (too implementation detail or just internal change).

wouterj added a commit that referenced this issue Jan 19, 2022
…dojulien, parijke, wouterj)

This PR was merged into the 5.3 branch.

Discussion
----------

[Security] Document the new remember me system

Fixes #15721, fixes #16149
Replaces #15464, replaces #15893
Ref #15908

In Symfony 5.3, along with the new authentication system, we also somewhat silently introduced a new remember me system. Time to update the remember me docs with all new features :)

This PR also includes 2 commits from open PRs in this repository. We've been very late with this one, and community members have already invested time in contributing necessary changes to the docs before. They deserve the credits :)

`@javiereguiluz` I'm sorry for not informing you of this work before, I see you just merged a third PR that is replaced by this one.

Commits
-------

5ac2d26 Document the new remember me system
2df2275 Added the way to activate remember me in the new authentication system
d36b949 Update remember_me.rst
@carsonbot
Copy link
Collaborator

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@wouterj
Copy link
Member

wouterj commented Jan 8, 2023

Hi @carsonbot, have a look at the checkboxes, it appears we did not fully solve this issue yet :)

@carsonbot carsonbot removed the Stalled label Jan 8, 2023
@OskarStark
Copy link
Contributor

I marked them all as checked because all issues/PRs have been resolved @wouterj

@wouterj
Copy link
Member

wouterj commented Jan 8, 2023

No, we closed all other issues in favor of this meta issue. The unchecked ones aren't solved yet.

I've reverted your changes :)

@OskarStark
Copy link
Contributor

Oh ok this is a bit missleading then

javiereguiluz added a commit that referenced this issue Apr 11, 2023
This PR was merged into the 5.4 branch.

Discussion
----------

[Security] Document required badges

Check one TODO of #15908

Fix already closed #15203

Commits
-------

cc85189 [Security] Document required badges
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue May 4, 2023
…rault)

This PR was merged into the 5.4 branch.

Discussion
----------

[Security] Improve security logout options

symfony#12243

Today, all options are documented under bold "Options Related to Logout Configuration". As suggested, create a section "logout" for options is a good thing.

I can also provide a full `configuration-block` with all options (after all options ?). If you're ok I can add it in another PR or here

Meta issue: symfony#15908

Commits
-------

e95b95a Improve security logout options
@alamirault
Copy link
Contributor

Hi,

We can toggle "[Security] Add concept of required passport badges" and "Missing security.form_login.logout reference in documentation "

For "[Security] Missing PHP example of configuration", I think php example is not needed on https://symfony.com/doc/current/security/user_providers.html#chain-user-provider. Maybe we should just talk about "Creating a Custom User Provider" before "Chain User Provider"

I really hope we can close this 5.4 meta issue with few PR only. cc @alexandre-daubois 😄

javiereguiluz added a commit that referenced this issue Sep 25, 2023
…ples (alexandre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Security] [UserProvider] Add missing configuration examples

Part of #15908

Commits
-------

aa45ec7 [UserProvider] Add missing configuration examples
@alexandre-daubois
Copy link
Member

@javiereguiluz I think when my two new PR are merged and given @alamirault's comment, this issue may be closed! 🙂

javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Sep 27, 2023
…ple (alexandre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Security] [Authenticator] Improve the first example

Fix symfony#15886, part of symfony#15908

Commits
-------

bd58134 [Authenticator] Improve the first example
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Oct 4, 2023
…led authentication (alexandre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Security] Mention customizing successful and failed authentication

Fix symfony#4258, part of symfony#15908

Commits
-------

3526742 [Security] Mention customizing successful and failed authentication
@alexandre-daubois
Copy link
Member

It seems this one's now complete 🙌

@xabbuh xabbuh closed this as completed Oct 23, 2023
@alamirault
Copy link
Contributor

Happy to see this one closed. Congrats and thanks everyone 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants