-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[META] Symfony Security issues #15908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks Javier! I've checked some tasks that I believe don't need any documentation change (too implementation detail or just internal change). |
…dojulien, parijke, wouterj) This PR was merged into the 5.3 branch. Discussion ---------- [Security] Document the new remember me system Fixes #15721, fixes #16149 Replaces #15464, replaces #15893 Ref #15908 In Symfony 5.3, along with the new authentication system, we also somewhat silently introduced a new remember me system. Time to update the remember me docs with all new features :) This PR also includes 2 commits from open PRs in this repository. We've been very late with this one, and community members have already invested time in contributing necessary changes to the docs before. They deserve the credits :) `@javiereguiluz` I'm sorry for not informing you of this work before, I see you just merged a third PR that is replaced by this one. Commits ------- 5ac2d26 Document the new remember me system 2df2275 Added the way to activate remember me in the new authentication system d36b949 Update remember_me.rst
Thank you for this issue. |
Hi @carsonbot, have a look at the checkboxes, it appears we did not fully solve this issue yet :) |
I marked them all as checked because all issues/PRs have been resolved @wouterj |
No, we closed all other issues in favor of this meta issue. The unchecked ones aren't solved yet. I've reverted your changes :) |
Oh ok this is a bit missleading then |
…rault) This PR was merged into the 5.4 branch. Discussion ---------- [Security] Improve security logout options symfony#12243 Today, all options are documented under bold "Options Related to Logout Configuration". As suggested, create a section "logout" for options is a good thing. I can also provide a full `configuration-block` with all options (after all options ?). If you're ok I can add it in another PR or here Meta issue: symfony#15908 Commits ------- e95b95a Improve security logout options
Hi, We can toggle "[Security] Add concept of required passport badges" and "Missing security.form_login.logout reference in documentation " For "[Security] Missing PHP example of configuration", I think php example is not needed on https://symfony.com/doc/current/security/user_providers.html#chain-user-provider. Maybe we should just talk about "Creating a Custom User Provider" before "Chain User Provider" I really hope we can close this 5.4 meta issue with few PR only. cc @alexandre-daubois 😄 |
@javiereguiluz I think when my two new PR are merged and given @alamirault's comment, this issue may be closed! 🙂 |
…ple (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Security] [Authenticator] Improve the first example Fix symfony#15886, part of symfony#15908 Commits ------- bd58134 [Authenticator] Improve the first example
…led authentication (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Security] Mention customizing successful and failed authentication Fix symfony#4258, part of symfony#15908 Commits ------- 3526742 [Security] Mention customizing successful and failed authentication
It seems this one's now complete 🙌 |
Happy to see this one closed. Congrats and thanks everyone 🎉 |
In #15503 we're revamping Security docs. This meta-issue lists all security-related issues that are still pending. That way we can quickly check them and see if we've already fixed them in the new docs or even if we can ignore them because they are not relevant for docs:
The text was updated successfully, but these errors were encountered: