Skip to content

Update Doctrine AppBundle:Post syntax to Post::class #7892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weaverryan opened this issue May 10, 2017 · 2 comments
Closed

Update Doctrine AppBundle:Post syntax to Post::class #7892

weaverryan opened this issue May 10, 2017 · 2 comments
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required)
Milestone
2.7

Comments

@weaverryan
Copy link
Member

I believe this is now the preferred syntax and writing it is "easier" a bit more universally (PhpStorm with the Symfony plugin will autocomplete both, but a normal IDE will only autocomplete the second).

This should be updated everywhere in the 3.1 branch (first, currently-maintained version with a high even PHP version to support this).
@weaverryan weaverryan added actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) labels May 10, 2017
@weaverryan weaverryan mentioned this issue May 10, 2017
Closed
@xabbuh
Copy link
Member

xabbuh commented May 10, 2017

A quick note: Symfony 3.1 is not maintained anymore. ;) And I would by the way even make the change in the 2.7 branch as we already switched to the usage of FQCNs with the class constant in other places as well (to refer to form types for example).

@javiereguiluz javiereguiluz mentioned this issue May 15, 2017
Closed
@HeahDude HeahDude added this to the 2.7 milestone Jul 27, 2017
@ghost
Copy link

ghost commented Dec 1, 2017

This seems to be fixed in #7907.

@xabbuh xabbuh closed this as completed Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
2.7
Development

No branches or pull requests
3 participants
@weaverryan @xabbuh @HeahDude