Keeping documentation consistent #4937
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
there is no argument in form_end(). You can pass one because Twig ignores extra args, as done by PHP, but your documentation now tells that the argument is needed
Member
There was a problem hiding this comment.
hmm, sorry. It looks like it actually does something with the argument. I forgot it can do more than rendering the closing tag
Contributor
|
This should go into the 2.3 branch. |
Member
|
Thank you @thecatontheflat. Consistency is one of the most important bits of a documentation. I've merged it into the 2.3 branch (that's why this PR is not labelled as merged, but as closed instead). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.