Commit 286a0d9
committed
bug #819 [Translator] Prefix bundle and extension classes with "Ux" (Kocal)
This PR was merged into the 2.x branch.
Discussion
----------
[Translator] Prefix bundle and extension classes with "Ux"
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Features and deprecations must be submitted against branch main.
-->
While installing the package for the demo page, I've got the following issue:
> There is no extension able to load the configuration for "ux_translator" (in "/Users/kocal/workspace-os/symfony-ux/ux.symfony.com/config/packages/ux_translator.yaml"). Looked for namespace "ux_
translator", found ""framework", "twig", "twig_extra", "webpack_encore", "turbo", "mercure", "web_profiler", "monolog", "debug", "twig_component", "live_component", "chartjs", "cropperjs", "laz
y_image", "dropzone", "doctrine", "doctrine_migrations", "maker", "babdev_pagerfanta", "autocomplete", "notify", "react", "vue", "svelte", "translator"" in /Users/kocal/workspace-os/symfony-ux/
ux.symfony.com/config/packages/ux_translator.yaml (which is being imported from "/Users/kocal/workspace-os/symfony-ux/ux.symfony.com/src/Kernel.php").
<img width="1789" alt="image" src="https://user-images.githubusercontent.com/2103975/234497995-550ce874-8445-4dcf-a9bf-5368797be699.png">
(you can also see it in the recipe PR symfony/recipes#1185)
Indeed, I've used `ux_translator` for the `TreeBuilder`'s name and not `translator` (to prevent misundersting with Symfony's Translator PHP version), but the related Bundle and Extension classes were not named correctly.
After the fix, the bundle is correctly loaded:
<img width="1486" alt="image" src="https://user-images.githubusercontent.com/2103975/234498103-f791c0e8-0da2-4867-a3cd-65018774cee4.png">
Commits
-------
fb19c14 [Translator] Prefix bundle and extension classes with "Ux"File tree
5 files changed
+8
-8
lines changed- src/Translator
- src
- DependencyInjection
- tests
- Kernel
5 files changed
+8
-8
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
0 commit comments