bug #409 Unset TomSelect after destroying the Stimulus Controller (janklan)

weaverryan · weaverryan · commit 53421dd6fc85 · 2022-08-09T11:31:32.000-04:00
This PR was merged into the 2.x branch. Discussion ---------- Unset TomSelect after destroying the Stimulus Controller | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | [407](#407) | License | MIT Sometimes Stimulus re-uses an instance of a controller after it's destroyed and re-created - for example when a Live Twig Component re-renders. Without unsetting the variable, [connect() method thinks TomSelect is already in place, and does nothing](https://github.com/symfony/ux/blob/2.x/src/Autocomplete/assets/src/controller.ts#L21-L25). Commits ------- 01916e6 Unset tomSelect after destroying the instance
diff --git a/src/Autocomplete/assets/src/controller.ts b/src/Autocomplete/assets/src/controller.ts
@@ -41,6 +41,8 @@ export default class extends Controller {
 
     disconnect() {
         this.tomSelect.destroy();
+        // Fixes https://github.com/symfony/ux/issues/407
+        this.tomSelect = undefined;
     }
 
     #getCommonConfig(): Partial<TomSettings> {

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,8 @@ export default class extends Controller {`
`41`	`41`
`42`	`42`	`disconnect() {`
`43`	`43`	`this.tomSelect.destroy();`
	`44`	`+ // Fixes https://github.com/symfony/ux/issues/407`
	`45`	`+ this.tomSelect = undefined;`
`44`	`46`	`}`
`45`	`47`
`46`	`48`	`#getCommonConfig(): Partial<TomSettings> {`