[UX] Incorrect version 2.23.0 in assets/package.json of UX packages v2.24.0

[ToshY]

Describe Your Problem 🎯

UX packages released under v2.24.0 tag contain incorrect version in assets/package.json (2.23.0).

• https://github.com/symfony/stimulus-bundle/releases/tag/v2.24.0
• https://github.com/symfony/ux-lazy-image/releases/tag/v2.24.0
• https://github.com/symfony/ux-autocomplete/releases/tag/v2.24.0
• Possibly all/more ... ?

[Kocal]

Hi, when looking on npm I correctly see version 2.24.0, for example https://www.npmjs.com/package/@symfony/stimulus-bundle?activeTab=code or https://www.npmjs.com/package/@symfony/ux-leaflet-map?activeTab=code

However, that's true its broken in GitHub https://github.com/symfony/ux/blob/v2.24.0/src/StimulusBundle/assets/package.json#L5, but "that's fine", and I don't think we want to delete and re-create tag 2.24.0, it may breaks many things.

The thing is that npm packages are automatically released when a GitHub tag is created, I don't think there is something we can do here, except changing our release process (cc @kbond)

[ToshY]

Hi, when looking on npm I correctly see version 2.24.0, for example https://www.npmjs.com/package/@symfony/stimulus-bundle?activeTab=code or https://www.npmjs.com/package/@symfony/ux-leaflet-map?activeTab=code

However, that's true its broken in GitHub https://github.com/symfony/ux/blob/v2.24.0/src/StimulusBundle/assets/package.json#L5, but "that's fine", and I don't think we want to delete and re-create tag 2.24.0, it may breaks many things.

The thing is that npm packages are automatically released when a GitHub tag is created, I don't think there is something we can do here, except changing our release process (cc @kbond)

It indeed seems that the release process might be the cause: the tags were created before the source code in the assets/package.json were updated to reflect the new minor version.

This was just a heads-up as I did not know if you were aware of this.

p.s. Thanks for your work on publishing the assets to NPM @Kocal ; that seems to solve symfony/symfony#58678 for me as well 👍

[Kocal]

Thanks for telling us tho, I didn't think about it :)

Maybe there is something we can do, something quite common in the "JavaScript" world is to not configure version (or use something like 0.0.0-development) in package.json, making it explicit that the version in Git repository has no real impact.

Thus, I tend to agree that having the exact version in package.json files than the git tag would make 100% sense too, but it would requires more manual releasing steps.