Skip to content

[Autocomplete] potential BC break in the upcoming 2.x release #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1ed opened this issue Apr 15, 2023 · 1 comment · Fixed by #797
Closed

[Autocomplete] potential BC break in the upcoming 2.x release #793

1ed opened this issue Apr 15, 2023 · 1 comment · Fixed by #797

Comments

@1ed
Copy link
Contributor

1ed commented Apr 15, 2023

There is an, I think accidental, BC break in the 2.8-dev branch. Adding a new EntityAutocompleterInterface::getGroupBy method by #481.
@1ed 1ed changed the title [Autocomplete] potential BC break in the upcoming 2.8 release [Autocomplete] potential BC break in the upcoming 2.x release Apr 15, 2023
@wouterj
Copy link
Member

wouterj commented Apr 15, 2023

Good spot! We should instead do what was also commented on that PR: #481 (comment)

@1ed 1ed mentioned this issue Apr 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Autocomplete] Fix BC and trigger deprecation for EntityAutocompleterInterface 1ed/ux
2 participants
@1ed @wouterj