Skip to content

Commit ccbae35

Browse files
committed
bug #265 Fix 'plugin' typehint on Encore.addPlugin (Blackskyliner)
This PR was merged into the master branch. Discussion ---------- Fix 'plugin' typehint on Encore.addPlugin The `plugin` parameter is described as `{string}` but in fact we want to have instances of a Webpack plugin here. So I think we should use `object` here, which reflects the fact that all examples and known usages use an object there... Commits ------- 6d9525a Fix 'plugin' typehint on Encore.addPlugin
2 parents 2513be0 + 6d9525a commit ccbae35

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ class Encore {
292292
*
293293
* Encore.addPlugin(new MyWebpackPlugin(), PluginPriorities.DefinePlugin);
294294
*
295-
* @param {string} plugin
295+
* @param {object} plugin
296296
* @param {number} priority
297297
* @returns {Encore}
298298
*/

0 commit comments

Comments
 (0)