Skip to content

Fonts and images not working after update #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eberhapa opened this issue May 14, 2020 · 4 comments
Closed

Fonts and images not working after update #771

eberhapa opened this issue May 14, 2020 · 4 comments

Comments

@eberhapa
Copy link

Hi,

After updating to 0.30.0 fonts and images are not working with npm run watch (build folder empty). With npm run build everything is fine. Did something changed here?

Thanks,
Patrick

@ghost
Copy link

ghost commented May 14, 2020

Hi! We are running in the same issue at my company, but in our case it's only affecting fonts. I found that the problem comes from pull-request #760 (d697be8). It was working fine (fonts are emitted to build folder) up to revision 2eaa4ad and is broken (no font in build folder) since merge at revision 5429553.

I managed to find it by trying all of them from tag v0.29.1 (134f47a) to v0.30.0 (e597463), as the bug occurs since v0.30.0 according to our tests. To install package at specific revision, I used npm i @symfony/webpack-encore#revhash.

According to #760, the purpose was to upgrade clean-webpack-plugin from ^0.1.19 to ^3.0.0. Maybe one of its dependencies is the problem...

@Kocal
Copy link
Member

Kocal commented May 14, 2020

Maybe related: johnagan/clean-webpack-plugin#152

@mees-van-wel
Copy link

I got the same issue after running: npm audit fix wich upgraded it to v0.30.1. Fonts can't be loaded when I run encore dev --watch or npm run watch. But when I run encore production --watch or encore dev without the watch it works fine.

@weaverryan
Copy link
Member

Hi!

Try the new 0.30.2 release - in #772, I disabled an option in CleanWebpackPlugin. I believe there is a bug in their "watch" mode - I experienced a similar issue where files (in watch only) would disappear.

If you still have an issue with 0.30.2, please let us know by creating a new issue :).

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants