Skip to content

Commit 9ad9550

Browse files
committed
use event.preventDefault() in the useOutsideClick on Dialog's
When using a `Dialog`, we should prevent the default behaviour of the event that triggered the "close" in the `useOutsideClick` call. We recently made improvements to improve outside click behaviour on touch devices (#2572) but due to the `touchend` event, the touch is still forwarded and therefore a potential button _behind_ the "backdrop" will also be clicked. This is not what we want. Added the `event.preventDefault()` for the Dialog specifically because there are other places where we use `useOutsideClick` and where we _do_ want the behaviour where the click just continues. A concrete example of this is 2 `Menu`'s next to eachother where you open the first one, and then click on the second one. This should close first one (outside click) and open the second one (by not preventing the event)
1 parent 2b7a57e commit 9ad9550

File tree

2 files changed

+10
-2
lines changed
  • packages
    • @headlessui-react/src/components/dialog
    • @headlessui-vue/src/components/dialog

2 files changed

+10
-2
lines changed

packages/@headlessui-react/src/components/dialog/dialog.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,14 @@ function DialogFn<TTag extends ElementType = typeof DEFAULT_DIALOG_TAG>(
305305
if (hasNestedDialogs) return false
306306
return true
307307
})()
308-
useOutsideClick(resolveRootContainers, close, outsideClickEnabled)
308+
useOutsideClick(
309+
resolveRootContainers,
310+
(event) => {
311+
event.preventDefault()
312+
close()
313+
},
314+
outsideClickEnabled
315+
)
309316

310317
// Handle `Escape` to close
311318
let escapeToCloseEnabled = (() => {

packages/@headlessui-vue/src/components/dialog/dialog.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,8 @@ export let Dialog = defineComponent({
237237
})
238238
useOutsideClick(
239239
resolveRootContainers,
240-
(_event, target) => {
240+
(event, target) => {
241+
event.preventDefault()
241242
api.close()
242243
nextTick(() => target?.focus())
243244
},

0 commit comments

Comments
 (0)