Skip to content

Commit 668f28e

Browse files
benjamingrtargos
authored andcommitted
events: define event handler as enumerable
PR-URL: nodejs#35931 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 2198e9c commit 668f28e

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

lib/internal/event_target.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,9 @@ function defineEventHandler(emitter, name) {
591591
emitter.addEventListener(name, value);
592592
}
593593
eventHandlerValue = value;
594-
}
594+
},
595+
configurable: true,
596+
enumerable: true
595597
});
596598
}
597599
module.exports = {

test/parallel/test-eventtarget.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -517,3 +517,10 @@ let asyncTest = Promise.resolve();
517517
}));
518518
target.dispatchEvent(new Event('foo'));
519519
}
520+
{
521+
const target = new EventTarget();
522+
defineEventHandler(target, 'foo');
523+
const descriptor = Object.getOwnPropertyDescriptor(target, 'onfoo');
524+
strictEqual(descriptor.configurable, true);
525+
strictEqual(descriptor.enumerable, true);
526+
}

0 commit comments

Comments
 (0)