Fix [24d7f1a6] - crash on proc definition in namespace being deleted

Author: apnadkarni

generic/tclBasic.c

@@ -2414,6 +2414,7 @@ TclCreateObjCommandInNs(
 	Tcl_DeleteCommandFromToken(interp, (Tcl_Command) cmdPtr);
 	nsPtr = (Namespace *) TclEnsureNamespace(interp,
 		(Tcl_Namespace *) cmdPtr->nsPtr);
+	/* Note nsPtr may or may not be same as cmdPtr->nsPtr */
 	TclNsDecrRefCount(cmdPtr->nsPtr);
 
 	if (cmdPtr->flags & CMD_REDEF_IN_PROGRESS) {

generic/tclNamesp.c

@@ -2390,6 +2390,14 @@ TclEnsureNamespace(
     if (!(nsPtr->flags & NS_DYING)) {
 	    return namespacePtr;
     }
+    /*
+     * If a new namespace with the same name has been created already,
+     * return that. Otherwise, create a new one. Bug 24d7f1a695.
+     */
+    Tcl_Namespace *nsPtr2 = Tcl_FindNamespace(interp, nsPtr->fullName, NULL, 0);
+    if (nsPtr2 != NULL) {
+	return nsPtr2;
+    }
     return Tcl_CreateNamespace(interp, nsPtr->fullName, NULL, NULL);
 }
 

tests/basic.test

@@ -240,7 +240,18 @@ test basic-15.2 {Tcl_CreateObjCommand, Bug 0e4d88b650} -setup {
     namespace delete n
     rename deleter {}
 }
-
+test basic-15.3 {Tcl_CreateObjCommand, Bug 24d7f1a695} -body {
+    namespace eval ns {
+        proc p {} {}; proc q {} {};
+        namespace delete [namespace current];
+        proc p {} {}; proc q {} {}
+    }
+    # APN - current behavior is that namespace continues to exist
+    # as it is recreated by the proc calls after the ns delete.
+    # I am not sure this is consistent with proc ns::foo raising
+    # an error if ns does not exist. But whatever ...
+    namespace exists ns
+} -result 1
 
 test basic-16.1 {TclInvokeStringCommand} {emptyTest} {
 } {}