Skip to content

Commit c4d7b39

Browse files
committed
Silence SA1503 in favor of IDE0011
1 parent 702e7cc commit c4d7b39

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

Tdg5.StandardConventions.Tests/Data/EditorConfigRules/BlockScopedExpectations.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ public static void IDE0004_RemoveUnnecessaryCast()
4343
/// A method that contains a statement that should use braces, but does not.
4444
/// </summary>
4545
[CodeAnalysisViolationExpected("IDE0011", "Warning")]
46-
[IncidentalCodeAnalysisViolationExpected("SA1503")]
46+
[IncidentalCodeAnalysisViolationExpected(
47+
"SA1503", disabledReason: "SA1503 is silenced")]
4748
public static void IDE0011_SurroundBlocksOfCodeWithCurlyBraces()
4849
{
4950
if (true)

Tdg5.StandardConventions.Tests/Data/StyleCopRules/BlockScopedExpectations.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,8 @@ public static void SA1413_UseTrailingCommasInMultiLineInitializers()
479479
/// <summary>
480480
/// A method that contains a statement that should use braces, but does not.
481481
/// </summary>
482-
[CodeAnalysisViolationExpected("SA1503", "Warning")]
482+
[CodeAnalysisViolationExpected(
483+
"SA1503", "Warning", disabledReason: "SA1503 is silenced")]
483484
[IncidentalCodeAnalysisViolationExpected("IDE0011")]
484485
public static void SA1503_BracesMustNotBeOmitted()
485486
{

Tdg5.StandardConventions/Tdg5.StandardConventions.globalconfig

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,8 @@ dotnet_diagnostic.SA1501.severity = warning
768768
dotnet_diagnostic.SA1502.severity = warning
769769

770770
# SA1503: Braces should not be omitted.
771-
dotnet_diagnostic.SA1503.severity = warning
771+
# Motivation: Prefer IDE001 which covers the same cases and has a quick fix action.
772+
dotnet_diagnostic.SA1503.severity = silent
772773

773774
# SA1504: All accessors should be single-line or multi-line.
774775
dotnet_diagnostic.SA1504.severity = warning

0 commit comments

Comments
 (0)