test updates

Author: twalpole

lib/capybara/registrations/drivers.rb

@@ -36,6 +36,11 @@
     opts.add_argument('--disable-gpu') if Gem.win_platform?
     # Workaround https://bugs.chromium.org/p/chromedriver/issues/detail?id=2650&q=load&sort=-id&colspec=ID%20Status%20Pri%20Owner%20Summary
     opts.add_argument('--disable-site-isolation-trials')
+
+    # https://github.com/teamcapybara/capybara/issues/2796#issuecomment-2678172710
+    opts.add_argument('disable-background-timer-throttling')
+    opts.add_argument('disable-backgrounding-occluded-windows')
+    opts.add_argument('disable-renderer-backgrounding')
   end
 
   Capybara::Selenium::Driver.new(app, **{ :browser => :chrome, options_key => browser_options })

lib/capybara/selenium/driver.rb

@@ -367,6 +367,8 @@ def clear_session_storage
   end
 
   def clear_local_storage
+    # selenium-webdriver 4.30.0 removed HTML5 storage accessors -- not really sure why
+    # can we replicate this robustly via CDP?
     if @browser.respond_to? :local_storage
       @browser.local_storage.clear
     else

lib/capybara/spec/session/scroll_spec.rb

@@ -75,7 +75,8 @@
     scrolling_element.scroll_to(el, align: :center)
     el_center = el.evaluate_script('(function(rect){return (rect.top + rect.bottom)/2})(this.getBoundingClientRect())')
     scrollable_center = scrolling_element.evaluate_script('(this.clientHeight / 2) + this.getBoundingClientRect().top')
-    expect(el_center).to be_within(1).of(scrollable_center)
+    # Firefox reports floats and can be slightly outside 1 difference - make 2 instaed
+    expect(el_center).to be_within(2).of(scrollable_center)
   end
 
   it 'can scroll the scrolling element to the top' do

spec/selenium_spec_firefox.rb

@@ -187,8 +187,8 @@ module TestSessions
         session.find(:css, '#set-storage').click
         session.reset!
         session.visit('/with_js')
-        expect(session.driver.browser.local_storage.keys).to be_empty
-        expect(session.driver.browser.session_storage.keys).to be_empty
+        expect(session.driver.browser.execute_script('return localStorage.length')).to eq(0)
+        expect(session.driver.browser.execute_script('return sessionStorage.length')).to eq(0)
       end
 
       it 'does not clear storage when false' do
@@ -197,8 +197,8 @@ module TestSessions
         session.find(:css, '#set-storage').click
         session.reset!
         session.visit('/with_js')
-        expect(session.driver.browser.local_storage.keys).not_to be_empty
-        expect(session.driver.browser.session_storage.keys).not_to be_empty
+        expect(session.driver.browser.execute_script('return localStorage.length')).to eq(1)
+        expect(session.driver.browser.execute_script('return sessionStorage.length')).to eq(1)
       end
     end
   end