Allow to skip long-running migration #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! 🙏 |
anbraten
reviewed
Nov 5, 2023
Comment on lines
+100
to
+104
| // InitSchema sets a function that is run if no migration is found. | ||
| // The idea is preventing to run all migrations when a new clean database | ||
| // is being migratinx. In this function you should create all tables and | ||
| // foreign key necessary to your application. | ||
| func (x *Xormigrate) AllowLong(allow ...bool) { |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @techknowlogick!
I'm one of the Woodpecker maintainers and we have an open issue/discussion about moving our DB migration handling somewhere else/switch to this library (woodpecker-ci/woodpecker#2148).
However, our custom migrator has some features xormigrate does not have, so we can't switch to it currently.
One of these features is the possibility to skip migrations that will probably take a very long time to run (in our case logs migration). I added support for this to xormigrate in this PR.
If you don't want to extend this library, feel free to just close the PR.
Everything that was changed outside the
xormigrate.goandxormigrate_test.gofiles was done bygo mod tidyorgo fmt, I can undo these changes if you want don't them.