Skip to content

Commit acba2a9

Browse files
jycouettechniq
authored andcommitted
Swtich default to use Tokens enum
1 parent 2615f45 commit acba2a9

File tree

2 files changed

+57
-35
lines changed

2 files changed

+57
-35
lines changed

packages/svelte-ux/src/lib/components/settings.ts

Lines changed: 57 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -111,18 +111,23 @@ export function getFormatDate(options?: FormatDateOptions) {
111111

112112
presets: {
113113
day: {
114-
short:
115-
options?.presets?.day?.short ?? settings.formats?.dates?.presets?.day?.short ?? 'd M',
114+
short: options?.presets?.day?.short ??
115+
settings.formats?.dates?.presets?.day?.short ?? [
116+
DateToken.DayOfMonth_numeric,
117+
DateToken.Month_numeric,
118+
],
116119
default: options?.presets?.day?.default ??
117120
settings.formats?.dates?.presets?.day?.default ?? [
118121
DateToken.DayOfMonth_numeric,
119122
DateToken.Month_numeric,
120123
DateToken.Year_numeric,
121124
],
122-
long:
123-
options?.presets?.day?.long ??
124-
settings.formats?.dates?.presets?.day?.long ??
125-
'd MMM yyyy',
125+
long: options?.presets?.day?.long ??
126+
settings.formats?.dates?.presets?.day?.long ?? [
127+
DateToken.DayOfMonth_numeric,
128+
DateToken.Month_short,
129+
DateToken.Year_numeric,
130+
],
126131
custom,
127132
},
128133
dayTime: {
@@ -177,53 +182,71 @@ export function getFormatDate(options?: FormatDateOptions) {
177182
},
178183

179184
week: {
180-
short:
181-
options?.presets?.week?.short ?? settings.formats?.dates?.presets?.week?.short ?? 'd M',
182-
default:
183-
options?.presets?.week?.default ??
184-
settings.formats?.dates?.presets?.week?.default ??
185-
'd M yyyy',
186-
long:
187-
options?.presets?.week?.long ??
188-
settings.formats?.dates?.presets?.week?.long ??
189-
'd M yyyy',
185+
short: options?.presets?.week?.short ??
186+
settings.formats?.dates?.presets?.week?.short ?? [
187+
DateToken.DayOfMonth_numeric,
188+
DateToken.Month_numeric,
189+
],
190+
default: options?.presets?.week?.default ??
191+
settings.formats?.dates?.presets?.week?.default ?? [
192+
DateToken.DayOfMonth_numeric,
193+
DateToken.Month_numeric,
194+
DateToken.Year_numeric,
195+
],
196+
long: options?.presets?.week?.long ??
197+
settings.formats?.dates?.presets?.week?.long ?? [
198+
DateToken.DayOfMonth_numeric,
199+
DateToken.Month_numeric,
200+
DateToken.Year_numeric,
201+
],
190202
custom,
191203
},
192204
month: {
193205
short:
194-
options?.presets?.month?.short ?? settings.formats?.dates?.presets?.month?.short ?? 'MMM',
206+
options?.presets?.month?.short ??
207+
settings.formats?.dates?.presets?.month?.short ??
208+
DateToken.Month_short,
195209
default:
196210
options?.presets?.month?.default ??
197211
settings.formats?.dates?.presets?.month?.default ??
198-
'MMM',
212+
DateToken.Month_short,
199213
long:
200-
options?.presets?.month?.long ?? settings.formats?.dates?.presets?.month?.long ?? 'MMMM',
214+
options?.presets?.month?.long ??
215+
settings.formats?.dates?.presets?.month?.long ??
216+
DateToken.Month_long,
201217
custom,
202218
},
203219
monthYear: {
204-
short:
205-
options?.presets?.monthsYear?.short ??
206-
settings.formats?.dates?.presets?.monthsYear?.short ??
207-
'MMM yy',
208-
default:
209-
options?.presets?.monthsYear?.default ??
210-
settings.formats?.dates?.presets?.monthsYear?.default ??
211-
'MMMM yyyy',
212-
long:
213-
options?.presets?.monthsYear?.long ??
214-
settings.formats?.dates?.presets?.monthsYear?.long ??
215-
'MMMM yyyy',
220+
short: options?.presets?.monthsYear?.short ??
221+
settings.formats?.dates?.presets?.monthsYear?.short ?? [
222+
DateToken.Month_short,
223+
DateToken.Year_2Digit,
224+
],
225+
default: options?.presets?.monthsYear?.default ??
226+
settings.formats?.dates?.presets?.monthsYear?.default ?? [
227+
DateToken.Month_long,
228+
DateToken.Year_numeric,
229+
],
230+
long: options?.presets?.monthsYear?.long ??
231+
settings.formats?.dates?.presets?.monthsYear?.long ?? [
232+
DateToken.Month_long,
233+
DateToken.Year_numeric,
234+
],
216235
custom,
217236
},
218237
year: {
219238
short:
220-
options?.presets?.year?.short ?? settings.formats?.dates?.presets?.year?.short ?? 'yy',
239+
options?.presets?.year?.short ??
240+
settings.formats?.dates?.presets?.year?.short ??
241+
DateToken.Year_2Digit,
221242
default:
222243
options?.presets?.year?.default ??
223244
settings.formats?.dates?.presets?.year?.default ??
224-
'yyyy',
245+
DateToken.Year_numeric,
225246
long:
226-
options?.presets?.year?.long ?? settings.formats?.dates?.presets?.year?.long ?? 'yyyy',
247+
options?.presets?.year?.long ??
248+
settings.formats?.dates?.presets?.year?.long ??
249+
DateToken.Year_numeric,
227250
custom,
228251
},
229252
},

packages/svelte-ux/src/routes/docs/utils/format/+page.svelte

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,6 @@
293293
<div class="grid grid-cols-3 gap-4">
294294
<div>
295295
<h3>short</h3>
296-
<!-- TODO JYC QUESTION: before: Mar, suggestion as default: 3 -->
297296
<Preview>
298297
{format(myDate, PeriodType.Month, {
299298
variant: 'short',

0 commit comments

Comments
 (0)